Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode warning text color in tax and delete app modal #5317

Merged
merged 3 commits into from
Dec 11, 2024
+10 −2
Merged

Fix dark mode warning text color in tax and delete app modal #5317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99824ab
Fix dark mode warning text color
poulch Dec 11, 2024
e838613
Add changeset
poulch Dec 11, 2024
df23cfc
Merge branch 'main' into merx-549-fix-dark-mode-colors
poulch Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-kangaroos-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Warning banner in tax settings and delete app modal now display properly in dark mode
4 changes: 3 additions & 1 deletion src/apps/components/AppDeleteDialog/AppDeleteDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ const AppDeleteDialog: React.FC<AppDeleteDialogProps> = ({
borderColor="warning1"
borderStyle="solid"
>
<Text size={2}>{intl.formatMessage(msgs.deleteAppWarning)}</Text>
<Text size={2} color="warning1">
{intl.formatMessage(msgs.deleteAppWarning)}
</Text>
</Box>
{getMainText()} <FormattedMessage {...msgs.deleteAppQuestion} />
</Box>
Expand Down
3 changes: 2 additions & 1 deletion src/taxes/components/LegacyFlowWarning.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@ export const LegacyFlowWarning: React.FC<{
display="flex"
alignItems="center"
backgroundColor="warning1"
color="warning1"
padding={2}
gap={1}
borderRadius={3}
marginTop={1}
marginBottom={1}
>
<WarningIcon size="small" color="warning1" />
<Text size={2}>
<Text size={2} color="warning1">
{intl.formatMessage({
defaultMessage: "Legacy flow detected - select tax strategy from dropdown",
id: "k20lqw",
Expand Down
Loading