Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash during assigning product when has no channel #5300

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Dec 4, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@poulch poulch requested a review from a team as a code owner December 4, 2024 09:55
Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: e29db28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5300 December 4, 2024 10:01 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5300 December 5, 2024 08:48 Destroyed
@poulch poulch merged commit bf001d7 into main Dec 5, 2024
15 checks passed
@poulch poulch deleted the merx-1090-product-modal-error branch December 5, 2024 10:32
poulch added a commit that referenced this pull request Dec 5, 2024
* The Product is not available in voucher when it has no channels

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants