Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ONBOARDING_USER_JOINED_DATE_THRESHOLD to wokflows #5290

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Nov 28, 2024

We have to setup 3 variables in github:

  • CLOUD_ONBOARDING_USER_JOINED_DATE_THRESHOLD
  • DEV_ONBOARDING_USER_JOINED_DATE_THRESHOLD
  • STAGING_ONBOARDING_USER_JOINED_DATE_THRESHOLD

Falback is set to release date, I assume tomorrow: 2024-11-29

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 6ce8522

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5290 November 28, 2024 13:25 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5290 November 29, 2024 08:34 Destroyed
@poulch poulch marked this pull request as ready for review November 29, 2024 08:34
@poulch poulch requested review from a team as code owners November 29, 2024 08:34
andrzejewsky
andrzejewsky previously approved these changes Nov 29, 2024
NyanKiyoshi
NyanKiyoshi previously approved these changes Nov 29, 2024
Copy link
Member

@NyanKiyoshi NyanKiyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly grammar changes

.changeset/early-toes-occur.md Outdated Show resolved Hide resolved
@poulch poulch dismissed stale reviews from NyanKiyoshi and andrzejewsky via 6ce8522 November 29, 2024 11:31
@poulch poulch merged commit 4add531 into main Nov 29, 2024
11 of 12 checks passed
@poulch poulch deleted the merx-1294-onboarding-env-workflow branch November 29, 2024 11:34
poulch added a commit that referenced this pull request Nov 29, 2024
* Add ONBOARDING_USER_JOINED_DATE_THRESHOLD to wokflows

* Update fallback date

* Add changeset

* Update .changeset/early-toes-occur.md

Co-authored-by: Mikail <[email protected]>

---------

Co-authored-by: Mikail <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants