-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ONBOARDING_USER_JOINED_DATE_THRESHOLD to wokflows #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ce8522 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andrzejewsky
previously approved these changes
Nov 29, 2024
NyanKiyoshi
previously approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly grammar changes
Co-authored-by: Mikail <[email protected]>
poulch
dismissed stale reviews from NyanKiyoshi and andrzejewsky
via
November 29, 2024 11:31
6ce8522
NyanKiyoshi
approved these changes
Nov 29, 2024
andrzejewsky
approved these changes
Nov 29, 2024
poulch
added a commit
that referenced
this pull request
Nov 29, 2024
* Add ONBOARDING_USER_JOINED_DATE_THRESHOLD to wokflows * Update fallback date * Add changeset * Update .changeset/early-toes-occur.md Co-authored-by: Mikail <[email protected]> --------- Co-authored-by: Mikail <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to setup 3 variables in github:
CLOUD_ONBOARDING_USER_JOINED_DATE_THRESHOLD
DEV_ONBOARDING_USER_JOINED_DATE_THRESHOLD
STAGING_ONBOARDING_USER_JOINED_DATE_THRESHOLD
Falback is set to release date, I assume tomorrow: 2024-11-29
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description