Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add paragraph component #867

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Add paragraph component #867

merged 5 commits into from
Oct 4, 2024

Conversation

Cloud11PL
Copy link
Member

I want to merge this change because...

This PR closes #...

Screenshots

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • The storybook story is created and documentation is properly generated.
  • New component is wrapped in forwardRef.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 809420f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/macaw-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 11:15am

@Cloud11PL Cloud11PL added the release dev tag Release pkg to npm with @dev tag label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20241002141613.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20241002142200.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20241003093858.

Install it with:

pnpm add @saleor/[email protected]

poulch
poulch reviewed Oct 3, 2024
View reviewed changes
src/components/Paragraph/Paragraph.tsx Outdated

export const Paragraph = forwardRef<HTMLSpanElement, TextProps>(
({ ...rest }, ref) => {
return <Text ref={ref} display="block" {...rest} />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Would be great that paragraph has p tag not span which is default

@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20241003125154.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL marked this pull request as ready for review October 4, 2024 10:29
@Cloud11PL Cloud11PL requested a review from a team as a code owner October 4, 2024 10:29
@Cloud11PL Cloud11PL requested review from witoszekdev and poulch and removed request for a team October 4, 2024 10:29
@andrzejewsky andrzejewsky self-requested a review October 4, 2024 11:14
@Cloud11PL Cloud11PL merged commit ecffb8c into main Oct 4, 2024
8 of 10 checks passed
@Cloud11PL Cloud11PL deleted the add-paragraph-component branch October 4, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poulch poulch poulch approved these changes

@andrzejewsky andrzejewsky andrzejewsky approved these changes

@witoszekdev witoszekdev Awaiting requested review from witoszekdev witoszekdev is a code owner automatically assigned from saleor/ui-guild

Assignees
No one assigned
Labels
release dev tag Release pkg to npm with @dev tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cloud11PL @andrzejewsky @poulch