Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50775 Grader: Add Feedback Comment button should still appear when clicking on (should be same behavior like Add Private Notes) #13118

Merged
merged 1 commit into from
Dec 20, 2024
Merged

SAK-50775 Grader: Add Feedback Comment button should still appear when clicking on (should be same behavior like Add Private Notes) #13118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions ...mponents/tool/src/main/frontend/packages/sakai-grader/src/sakai-grader-rendering-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,19 +528,17 @@ export const graderRenderingMixin = Base => class extends Base {

<div id="grader-controls-block" class="${this._rubricShowing || this._rubricStudentShowing ? "d-none" : "d-block"}">
<div class="grader-block">
${this._feedbackCommentEditorShowing ? nothing : html`
<div class="feedback-label grader-label content-button-block">
<button id="grader-feedback-button"
class="btn btn-link"
aria-controls="feedback-block"
@click=${this._toggleFeedbackCommentEditor}
aria-expanded="${this._feedbackCommentEditorShowing ? "true" : "false"}"
aria-label="${this._i18n.add_feedback_tooltip}"
title="${this._i18n.add_feedback_tooltip}">
${this._submission.feedbackComment ? this._i18n.edit_feedback_comment : this._i18n.add_feedback_comment}
</button>
</div>
`}
<div class="feedback-label grader-label content-button-block">
<button id="grader-feedback-button"
class="btn btn-link"
aria-controls="feedback-block"
@click=${this._toggleFeedbackCommentEditor}
aria-expanded="${this._feedbackCommentEditorShowing ? "true" : "false"}"
aria-label="${this._i18n.add_feedback_tooltip}"
title="${this._i18n.add_feedback_tooltip}">
${this._submission.feedbackComment ? this._i18n.edit_feedback_comment : this._i18n.add_feedback_comment}
</button>
</div>
<div class="sak-banner-warn ms-2 ${this._feedbackCommentRemoved ? "d-block" : "d-none"}">${this._i18n.removed}</div>

${this._submission.feedbackComment ? html`
Expand Down
Loading