SAK-43953 PA System: Banner Dismissal Resets Upon Any Form of Update #11977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaljaykam
changed the title
kunaljaykam
force-pushed
the
SAK-43953
branch
from
7410985 to
bbf2288
Compare
ern
reviewed
Oct 13, 2023
| @@ -89,6 +91,12 @@ protected void handleCreateOrUpdate(HttpServletRequest request, Map<String, Obje | |||
| String uuid = extractId(request); | |||
| BannerForm bannerForm = BannerForm.fromRequest(uuid, request); | |||
|
|
|||
| User currentUser = UserDirectoryService.getCurrentUser(); | |||
There was a problem hiding this comment.
It would be ideal not to use the cover but if you need to it would be best to init the service in the contstructor like the other services
ern
reviewed
Oct 13, 2023
| @@ -89,6 +91,12 @@ protected void handleCreateOrUpdate(HttpServletRequest request, Map<String, Obje | |||
| String uuid = extractId(request); | |||
| BannerForm bannerForm = BannerForm.fromRequest(uuid, request); | |||
|
|
|||
| User currentUser = UserDirectoryService.getCurrentUser(); | |||
| if (currentUser == null) { | |||
| return; | |||
There was a problem hiding this comment.
before returning it might make sense to add an error?
kunaljaykam
force-pushed
the
SAK-43953
branch
from
b6b372f to
385f8c2
Compare
|
Thanks @adrianfish for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-43953