SAK-49345 Switch from Base62 to a variant of Base64 #11976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottenhoff
reviewed
Oct 9, 2023
basiclti/tsugi-util/src/test/org/tsugi/util/Base64DoubleUrlEncodeSafeTest.java
Outdated
Show resolved
Hide resolved
ottenhoff
reviewed
Oct 9, 2023
| "Testing encoding and decoding.", | ||
| "12345", | ||
| "This is a longer string with more characters.", | ||
| "A tree 🌲 was here", |
There was a problem hiding this comment.
shouldn't one of these be a really complex url esp one with an underscore?
ern
reviewed
Oct 9, 2023
Comment on lines
11
to
13
| /* This code was written by ChatGPT with the following prompt | ||
| * Please write a unit test for a Base64DoubleUrlEncodeSafe class | ||
| */ |
ern
reviewed
Oct 9, 2023
| Base64DoubleUrlEncodeSafe.decode(invalidBase64DoubleUrlEncodeSafeString); | ||
| fail("Expected IllegalArgumentException for invalid Base64DoubleUrlEncodeSafe string"); | ||
| } catch (Exception e) { | ||
| // Expected exception |
There was a problem hiding this comment.
you could also assert that an exception was caught, this is a good idea when an exception is expected
csev
changed the title
ern
approved these changes
Oct 17, 2023
ern
pushed a commit
that referenced
this pull request
Oct 19, 2023
(cherry picked from commit 2ea87c8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @ern and @jonespm - You were right. This commit switches to using Base64 URL Safe Encoding with a small adjustment to make double url encoding not a problem but without building our own Base62 implementation. This in essence reverts the Base62 patch and replace it with an adjusted Base64 encoder.