SAK-49341 Announcement NPE while viewing dashboard when announcements are merged from a site the user isn't a member of #11970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isn't a member of
ern
reviewed
Oct 9, 2023
| @@ -632,6 +633,8 @@ public Map<String, List<AnnouncementMessage>> getViewableAnnouncementsForCurrent | |||
|
|
|||
| public List<AnnouncementMessage> getViewableAnnouncementsForSite(String channelRef, Integer maxAgeInDays) { | |||
|
|
|||
| List<AnnouncementMessage> viewableAnnouncements = new Vector(); | |||
There was a problem hiding this comment.
@austin48 a Vector probably isn't needed here unless it would be used by another thread?
There was a problem hiding this comment.
Although the main case for this commit is returning an empty List where there is a failure getting messages, I used a Vector because in a successful case, getMessages() (from BaseAnnouncementService) returns a Vector.
There was a problem hiding this comment.
Minor thing, but if the variable is not going to be used elsewhere I would directly return "new Vector" at the end of the method.
|
@austin48 this needs a jira issue |
austin48
changed the title
…site user isn't a member of directly return empty vector at the end of the method
bgarciaentornos
approved these changes
Oct 11, 2023
ern
reviewed
Oct 11, 2023
...nnouncement-impl/impl/src/java/org/sakaiproject/announcement/impl/DbAnnouncementService.java
Outdated
Show resolved
Hide resolved
ern
changed the title
…announcement/impl/DbAnnouncementService.java
ern
reviewed
Oct 11, 2023
...nnouncement-impl/impl/src/java/org/sakaiproject/announcement/impl/DbAnnouncementService.java
Outdated
Show resolved
Hide resolved
…announcement/impl/DbAnnouncementService.java
ern
pushed a commit
that referenced
this pull request
Oct 31, 2023
… are merged from a site the user isn't a member of (#11970) Co-authored-by: Earle Nietzel <[email protected]> (cherry picked from commit 380c361)
ern
pushed a commit
that referenced
this pull request
Oct 31, 2023
… are merged from a site the user isn't a member of (#11970) Co-authored-by: Earle Nietzel <[email protected]> (cherry picked from commit 380c361)
ern
pushed a commit
that referenced
this pull request
Oct 31, 2023
… are merged from a site the user isn't a member of (#11970) Co-authored-by: Earle Nietzel <[email protected]> (cherry picked from commit 380c361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.