Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2U-16: Tests & Quizzes: Time limit per question or page #11952

Merged
merged 14 commits into from
Oct 17, 2023

Conversation

frasese
Copy link
Contributor

@frasese frasese commented Sep 28, 2023

This is paired with sakaiproject/sakai-reference#221

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<span>.&#160;</span>
<h:outputLabel id="isTimedTimeLimitLabel" value="#{assessmentSettingsMessages.assessment_is_timed_limit} " />

<input type="number" min="0" max="11" onchange="this.reportValidity()? document.getElementById('modifyPartForm:hiddenTimedHours').value=this.value : false" value="<h:outputText value="#{sectionBean.timedHours}" />"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es un input normal, se puede solucionar?

<h:inputHidden id="hiddenTimedHours" value="#{sectionBean.timedHours}" />
<h:outputLabel id="timedHoursLabel" value="#{assessmentSettingsMessages.timed_hours} " />

<input type="number" min="0" max="59" onchange="this.reportValidity()? document.getElementById('modifyPartForm:hiddenTimedMinutes').value=this.value : false" value="<h:outputText value="#{sectionBean.timedMinutes}" />"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es un input normal, se puede solucionar?

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@mpellicer
Copy link

Seems that we need a conversion script for this.

@@ -518,6 +518,7 @@ random_draw_msg=Parte honetako galderak ausaz sortzen dira galdera-biltzaile bat
random_draw_msg_published=Parte honetako galderak galderen gordailuak sortu ditu, <b>{0}</b>, on <b>{1}</b> at <b>{2}</b>. Parte honetako galderak editatzeko, egin klik hemen\: <b>Editatu galderak</b>.
random_draw_msg_no_date=Parte honetako galderak ausaz sortzen dira galdera gordailu batetik. Egin klik \u2018Aurreko azterketa\u2019 dioen tokian lagin bat ausaz ateratzeko.
random_update_questions=Eguneratu galderak
timed=Timed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PabloSanRoman could you please translate this? Thanks!

Comment on lines 393 to 397
# S2U-16
part_timed_info=If timed, students have until the end of the time limit, or until the Final Submission Deadline, whichever comes first, to submit their work. Their answers will be automatically saved and submitted at the expiration of the timer.
question_timed_info=If timed, students have until the end of the time limit, or until the Final Submission Deadline, whichever comes first, to submit their work. Their answers will be automatically saved and submitted at the expiration of the timer.
part_timeSelect_error=Please specify a time limit in hours and/or minutes, or select the "No" option.
question_timeSelect_error=Please specify a time limit in hours and/or minutes, or select the "No" option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PabloSanRoman could you please translate this? Thanks!

Comment on lines 581 to 592

#S2U-16 Timed Part/Question
timer_start=Start
partTimer_title=Time remaining for this part
partTimer_info_start=Timed part. Once you click \"Start\" you will have <b>{0}</b> to complete this part. It will be <b>submitted at that time</b>, regardless of whether you have answered all the questions.
partTimer_info_start_deadline=Timed part. Once you click \"Start\" you will have <b>{0} or until {1} whichever is shorter</b> to complete this part. It will be <b>submitted at that time</b>, regardless of whether you have answered all the questions.
partTimer_info_end=The time allowed for this part has expired.
questionTimer_title=Time remaining for this question
questionTimer_info_start=Timed question. Once you click \"Start\" you will have <b>{0}</b> to complete this question. It will be <b>submitted at that time</b>, regardless of whether you have answered it.
questionTimer_info_start_deadline=Timed question. Once you click \"Start\" you will have <b>{0} or until {1} whichever is shorter</b> to complete this question. It will be <b>submitted at that time</b>, regardless of whether you have answered it.
questionTimer_info_end=The time allowed for this question has expired.
title_not_available=Title not available yet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PabloSanRoman could you please translate this? Thanks!

Copy link
Contributor

@bgarciaentornos bgarciaentornos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing amazing work, thanks!

Copy link

@mpellicer mpellicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a monster Paco @frasese , terrific!

@@ -626,3 +626,15 @@ seb_download_seb=Download Safe Exam Browser
seb_launch_seb=Launch Safe Exam Browser
seb_quit_browser=Quit Safe Exam Browser
seb_preview_info=Assessments that are configured to use Safe Exam Browser can not be previewed.

#S2U-16 Timed Part/Question
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PabloSanRoman, I just found more missing properties for S2U-16. Could you translate them as well please?

timed=Timed

timer_start=Start
partTimer_title=Time remaining for this part
partTimer_info_start=Timed part. Once you click \"Start\" you will have <b>{0}</b> to complete this part. It will be <b>submitted at that time</b>, regardless of whether you have answered all the questions.
partTimer_info_start_deadline=Timed part. Once you click \"Start\" you will have <b>{0} or until {1} whichever is shorter</b> to complete this part. It will be <b>submitted at that time</b>, regardless of whether you have answered all the questions.
partTimer_info_end=The time allowed for this part has expired.
questionTimer_title=Time remaining for this question
questionTimer_info_start=Timed question. Once you click \"Start\" you will have <b>{0}</b> to complete this question. It will be <b>submitted at that time</b>, regardless of whether you have answered it.
questionTimer_info_start_deadline=Timed question. Once you click \"Start\" you will have <b>{0} or until {1} whichever is shorter</b> to complete this question. It will be <b>submitted at that time</b>, regardless of whether you have answered it.
questionTimer_info_end=The time allowed for this question has expired.
title_not_available=Title not available yet

part_timed_info=If timed, students have until the end of the time limit, or until the Final Submission Deadline, whichever comes first, to submit their work. Their answers will be automatically saved and submitted at the expiration of the timer.
question_timed_info=If timed, students have until the end of the time limit, or until the Final Submission Deadline, whichever comes first, to submit their work. Their answers will be automatically saved and submitted at the expiration of the timer.
part_timeSelect_error=Please specify a time limit in hours and/or minutes, or select the "No" option.
question_timeSelect_error=Please specify a time limit in hours and/or minutes, or select the "No" option.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stetsche , here they are:
timed=Tenporizatua

timer_start=Hasi
partTimer_title=Falta den denbora parte honetan
partTimer_info_start=Parte tenporizatua. "Hasi" botoia sakatu ondoren {0} izango duzu parte hau bukatzeko. Une horretan bidaliko da, galdera guztiak erantzun dituzun edo ez alde batera utzita.
partTimer_info_start_deadline= Parte tenporizatua. "Hasi" botoia sakatu ondoren {0} izango duzu partea bukatzeko, edo data hau arte, {1}, (lehenengo gertatzen dena). Une horretan bidaliko da, galdera guztiak erantzun dituzun edo ez alde batera utzita.
partTimer_info_end=Amaitu da parte hau egiteko denbora.
questionTimer_title=Galdera honetarako geratzen den denbora
questionTimer_info_start=Galdera tenporizatua. "Hasi" botoia sakatu ondoren, {0} izango duzu galderari erantzuteko. Une horretan bidaliko da, erantzun duzun edo ez alde batera utzita.
questionTimer_info_start_deadline=Galdea tenporizatua. "Hasi" botoia sakatu ondoren {0} izango duzu galderari erantzuteko, edo data hau arte, {1}, (lehenengo gertatzen dena). Une horretan bidaliko da, erantzun duzun edo ez alde batera utzita.
questionTimer_info_end=Galdera hau egiteko denbora agortu da.
title_not_available=Titulua ez dago erabilgarria oraindik

part_timed_info=Parte hau tenporizatuta badago ikasleek azterketa bidali ahalko dute denbora-muga hori amaitu arte edo azterketaren "Entregatzeko data berantiarra" arte, lehenengo gertatzen dena. Erantzunak automatikoki gorde eta bidaliko dira tenporizadorea amaitzen denean.
question_timed_info=Tenporizatuta badago, ikasleek azterketa bidali ahalko dute denbora-muga hori amaitu arte edo azterketaren "Entregatzeko data berantiarra" arte, lehenengo gertatzen dena. Erantzunak automatikoki gorde eta bidaliko dira tenporizadorea amaitzen denean.
part_timeSelect_error=Zehaztu denbora-muga bat ordu eta/edo minututan, edo hautatu "Ez" aukera.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PabloSanRoman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants