SAK-48489 Gradebook: students no longer have the option to ungroup/gr…

…oup by category (#11959)
sakaiproject · Oct 3, 2023 · 6ec64fd · 6ec64fd
1 parent c829788
commit 6ec64fd
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 36 deletions.
diff --git a/...bookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.html b/...bookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.html
@@ -6,7 +6,7 @@
 <wicket:panel>
 	<wicket:enclosure child="categoriesList">
 		<div wicket:id="toggleActions" class="float-end">
-			<a href="javascript:void(0);" class="button" id="toggleCategories" wicket:id="toggleCategoriesLink" aria-controls="gradeSummaryTable"><wicket:message key="label.toolbar.togglecategories"></wicket:message></a>
+			<a href="javascript:void(0);" class="btn-link si" id="toggleCategories" wicket:id="toggleCategoriesLink" aria-controls="gradeSummaryTable"><wicket:message key="label.toolbar.togglecategories"></wicket:message></a>
 			<a href="javascript:void(0);" class="gb-summary-expand-all" wicket:id="expandCategoriesLink" aria-controls="gradeSummaryTable"><wicket:message key="label.studentsummary.expandall"></wicket:message></a>
 			<a href="javascript:void(0);" class="gb-summary-collapse-all" wicket:id="collapseCategoriesLink" aria-controls="gradeSummaryTable"><wicket:message key="label.studentsummary.collapseall"></wicket:message></a>
 		</div>

diff --git a/...bookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.java b/...bookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.java
@@ -121,9 +121,8 @@ public void onBeforeRender() {
 			@Override
 			protected void onInitialize() {
 				super.onInitialize();
-				if (GradeSummaryTablePanel.this.isGroupedByCategory) {
-					add(new AttributeAppender("class", " on"));
-				}
+				String iconCssClass = GradeSummaryTablePanel.this.isGroupedByCategory ? " si-check-square" : " si-empty-square";
+				add(new AttributeAppender("class", iconCssClass));
 				add(new AttributeModifier("aria-pressed", GradeSummaryTablePanel.this.isGroupedByCategory));
 			}
 

diff --git a/library/src/skins/default/src/sass/modules/tool/gradebook/_gradebook.scss b/library/src/skins/default/src/sass/modules/tool/gradebook/_gradebook.scss
@@ -1282,14 +1282,15 @@
    *                      Gradebook Print styles                      *
    * **************************************************************** */
 
-   .gb-summary-expand-all,
-   .gb-summary-collapse-all,
-   .gb-summary-category-toggle,
-   #toggleCategories,
-   #gradeSummaryTable-sticky
-   .tablesorter-icon {
+  @media print {
+
+  .gb-summary-expand-all,
+  .gb-summary-collapse-all,
+  .gb-summary-category-toggle,
+  #toggleCategories,
+  #gradeSummaryTable-sticky .tablesorter-icon {
     display: none;
-   }
+  }
 
   .gb-summary-grade-panel {
     height: auto !important;
@@ -1303,6 +1304,9 @@
     page-break-inside: avoid;
     page-break-after:auto;
   }
+
+}
+
   /* ********************************************************************* *
    *                      Gradebook Settings styles                        *
    * ********************************************************************* */

diff --git a/library/src/skins/default/src/sass/modules/tool/gradebook/gradebook-print.css b/library/src/skins/default/src/sass/modules/tool/gradebook/gradebook-print.css