Feat: add option to set default theme in _config.vivia.yml #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Allow user to set the default theme to
light
/dark
, or useauto
to auto switch theme based on user's system theme, when user visiting the blog for the first time.Note: If user never clicked on theme-switch button in
auto
mode, then it will always follow system theme.Tested option:
light
,dark
,auto
,random_string
, and commented it out.Justification:
Instead of reading values from
_config.vivia.yml
and directly apply it in the ejs, this will prevent code injection from yml file.Additional:
After consideration, I add "fix the theme to light/dark once being set" behavior in
auto
mode, which I believe is better for user experience. Or the light/dark switch button will be useless since user needs to switch pages.Code difference: