fix: error/help messages

[infiniteregrets]

No description provided.

[infiniteregrets]

this does not work apparently :o

[shikhar]

Work in what way?

[infiniteregrets]

it doesnt render out the miette diagnostic! not sure why

[vrongmeal]

It's because it's a clap parse error

[infiniteregrets]

yup I assumed clap won't show that after trying a few hacks, feel free to push here in case you find a better way

[vrongmeal]

I don't think there's a better way, but, we can assume in this case, it isn't a valid basin name. None scheme basically means that the input is at-max a valid file path which doesn't strongly imply that the user tried to input a URI. We can just return the parse basin error in this case?

diff --git a/src/types.rs b/src/types.rs
index 14d931a..cc249d4 100644
--- a/src/types.rs
+++ b/src/types.rs
@@ -33,7 +33,7 @@ fn parse_maybe_basin_or_uri(
         }
         Err(parse_basin_err) => {
             // Should definitely be a URI else error.
-            let uri = http::Uri::from_str(s).map_err(|_| parse_basin_err)?;
+            let uri = http::Uri::from_str(s).map_err(|_| parse_basin_err.clone())?;

             match uri.scheme_str() {
                 Some("s2") => (),
@@ -45,10 +45,9 @@ fn parse_maybe_basin_or_uri(
                     )));
                 }
                 None => {
-                    return Err(BasinNameOrUriParseError::InvalidUri(miette::miette!(
-                        help = "Make sure the URI starts with 's2://'",
-                        "Missing URI scheme"
-                    )))
+                    // It's probably not an attempt to enter a URI. Safe to
+                    // assume this is simply an invalid basin.
+                    return Err(parse_basin_err.into());
                 }
             };

[vrongmeal]

As far as trying to return error with help message goes, we'll just have to format the error ourselves or do what you did.

What you did in this PR isn't the worst option. I would, though, prefer we do it consistently for all the commands.

[vrongmeal]

Looks good. Just need to undo some changes :)

[vrongmeal]

Can remove this.

[vrongmeal]

We can undo this.