Use OS provided temporary directory for tests #4361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
wasm-bindgen-test-runner
has some logic in place to detect thetarget
folder generated by Cargo and places and hosts any generated files from there.This PR changes this to simply use the OS provided temporary directory through
tempfile
, which was already in our dependency tree viarouille
(viamultipart
), to generate a uniquely temporary folder. This doesn't just remove the error-prone logic, but also allows us to confidently allow tests to run in parallel.