Migrate wasm-bindgen-cli to clap
#4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
commented
Dec 15, 2024
| @@ -139,8 +137,7 @@ pub fn execute( | |||
| .env("NODE_PATH", env::join_paths(&path).unwrap()) | |||
| .arg("--expose-gc") | |||
| .args(&extra_node_args) | |||
| .arg(&js_path) | |||
| .args(args), | |||
There was a problem hiding this comment.
I assume at some point this was used to be able to pass arguments into Node.js/Deno. But this was already not functional because when wasm-bindgen-test-runner started parsing arguments in JS it would fail during runtime.
Merged
daxpedda
added a commit
to daxpedda/wasm-bindgen
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
wasm-bindgen-cli,wasm-bindgen-test-runnerandwasm2es6jstoclap.wasm-bindgen-test-runnerwas parsing arguments in JS, this is now moved into the CLI viaclapand is passed into JS fully parsed.