Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify no_std implementation #4347

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Simplify no_std implementation #4347

merged 1 commit into from
Dec 9, 2024

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Dec 9, 2024

By removing the usage of thread_local! entirely, we can simplify the code around no_std.

@daxpedda daxpedda force-pushed the no_std-refactor branch 3 times, most recently from a45f9eb to 65166c9 Compare December 9, 2024 11:04
@RunDevelopment
Copy link
Contributor

Does that mean string interning works on no_std now? If so, could you please update the feature documentation?

@daxpedda
Copy link
Collaborator Author

daxpedda commented Dec 9, 2024 •
edited
Loading

Does that mean string interning works on no_std now?

It does not.

It uses a HashMap, so we either stop using the std one or come up with a different implementation.
In any case, its unrelated to this PR.

@daxpedda daxpedda merged commit 8fa299f into rustwasm:main Dec 9, 2024
67 checks passed
daxpedda added a commit to daxpedda/wasm-bindgen that referenced this pull request Dec 19, 2024
@daxpedda
Simplify no_std implementation (rustwasm#4347)
84e0d6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daxpedda @RunDevelopment