-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a typescript test (not just a compile test) for enums #3740
Conversation
9c6f801
to
440191f
Compare
440191f
to
c167c8d
Compare
Friendly ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Liamolucko would you mind taking a look at this? Unfortunately I'm completely unfamiliar with TS, so I don't feel comfortable approving something like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't think this is super necessary, I think a compile test is enough: making sure that wasm-bindgen
works properly at runtime is already covered by the regular tests in tests/wasm
.
Having extra tests doesn't hurt though, so I'm fine to merge this regardless.
Co-authored-by: Liam Murphy <[email protected]>
Thanks, just for the motivation why I am doing this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Also changed from opt-in to opt-out for running TypeScript tests.
This will make sure that new tests are run by default.