-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parallel raytracing .gitignore #3606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we use the --no-typescript
flag instead?
snippets
would still be required though.
I'm not really sure why |
Sure! But since this now involves changing |
342fc6c
to
c0b7228
Compare
e1b21c9
to
44496d0
Compare
This is LGTM, just waiting for us to figure out if we can remove the |
be324c9
to
685f446
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Oh, um... heads up that I had rebased this on #3603. This is because I thought #3603 would be merged first, and because the The end result of all this is that you have already merged most of #3603, probably without realizing it😬 |
... I sincerely apologize, I've somehow missed that, this is most definitely not your fault. |
@jthemphill if you don't mind re-opening this again after we finish in #3603, it would be appreciated. |
I included this change in #3603, so you don't have to re-open this. |
Running the build script creates some
*.d.ts
files and asnippets
folder. Adding these to the.gitignore
.