Skip to content

Commit

Permalink
guide: add missing and fix incorrect testing info (#3629)
Browse files Browse the repository at this point in the history
* guide: add missing and fix incorrect testing info

in the contributing section.

Some tests need `WASM_BINDGEN_SPLIT_LINKED_MODULES` set to run through,
and the macro ui-tests are not a workspace package anymore

Signed-off-by: Dominik Csapak <[email protected]>

* guide: improve macro test invocation

by using `-p wasm-bindgen-macro` instead of changing dir to `crates/macro`

Signed-off-by: Dominik Csapak <[email protected]>

---------

Signed-off-by: Dominik Csapak <[email protected]>
  • Loading branch information
flumm authored Sep 21, 2023
1 parent e14a7ad commit ba244b9
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions guide/src/contributing/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ These are the largest test suites, and most common to run in day to day
Node.js or a headless browser via the WebDriver protocol.

```bash
cargo test --target wasm32-unknown-unknown
WASM_BINDGEN_SPLIT_LINKED_MODULES=1 cargo test --target wasm32-unknown-unknown
```

See [the `wasm-bindgen-test` crate's
Expand All @@ -34,8 +34,11 @@ cargo test -p webidl-tests --target wasm32-unknown-unknown
These tests assert that we have reasonable error messages that point to the
right source spans when the `#[wasm_bindgen]` proc-macro is misused.

You can run these tests by running `cargo test` for the `wasm-bindgen-macro`
crate:

```
cargo test -p ui-tests
cargo test -p wasm-bindgen-macro
```

## The `js-sys` Tests
Expand Down

0 comments on commit ba244b9

Please sign in to comment.