Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cargo.lock (2) #424

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Update Cargo.lock (2) #424

merged 1 commit into from
Dec 9, 2023

Conversation

ranile
Copy link
Collaborator

@ranile ranile commented Dec 9, 2023

#423 but without raising MSRV

@ranile ranile mentioned this pull request Dec 9, 2023
Closed
@ranile ranile requested a review from futursolo December 9, 2023 09:53
futursolo
futursolo reviewed Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#423 also updates crates/history/Cargo.toml to include wasm-bindgen = "0.2.88", so it will be respected when used as a dependency.

If you want to keep #423 to update wasm-bindgen, that’s fine with me as well.

@futursolo
Copy link
Collaborator

In addition, could you please wait until gloo-history removed the wasi compiler flags before releasing the next version?

See: #411 (comment)

@langyo
Copy link
Contributor

langyo commented Dec 9, 2023

In addition, could you please wait until gloo-history removed the wasi compiler flags before releasing the next version?

See: #411 (comment)

If necessary, I'll removing additional WASI judgment tags when this PR has merged.

futursolo
futursolo approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s merge this and address Cargo.toml in #423.

@futursolo futursolo marked this pull request as ready for review December 9, 2023 16:50
@futursolo futursolo merged commit 5f96627 into rustwasm:master Dec 9, 2023
20 checks passed
This was referenced Dec 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futursolo futursolo futursolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranile @futursolo @langyo