Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ansi-term PR 74): Shrink unsafe block in windows::enable_ansi_support() #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(ansi-term PR 74): Shrink unsafe block in windows::enable_ansi_support() #8

wants to merge 1 commit into from

Conversation

gierens
Copy link
Member

@gierens gierens commented Aug 29, 2023

@gierens
Copy link
Member Author

gierens commented Aug 29, 2023

The commit message needs to be revised before merging.

@gierens
Copy link
Member Author

gierens commented Aug 29, 2023 •
edited
Loading

Also someone with windows should review this ... or we need a windows test workflow.

@PThorpe92
Copy link
Member

Well I don't have any access to windows within reason. I think this one can stay put for now, but now that Eza supports windows again it couldn't hurt to add it to the workflow/tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gierens @PThorpe92 @peamaeq