Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wasm legacy abi #133952

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Remove wasm legacy abi #133952

wants to merge 7 commits into from

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 6, 2024 •
edited
Loading

Blocked on #133951 reaching stable.

Based on #133932 to avoid conflicts.

Closes #122532
Fixes #71871
Fixes #115666
Fixes #129486

@bjorn3 bjorn3 added O-wasm Target: WASM (WebAssembly), http://webassembly.org/ A-ABI Area: Concerning the application binary interface (ABI) labels Dec 6, 2024
@bjorn3 bjorn3 added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Dec 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2024
@bjorn3 bjorn3 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2024
@workingjubilee workingjubilee mentioned this pull request Dec 6, 2024
Open
@bjorn3 bjorn3 force-pushed the remove_wasm_legacy_abi branch from 88f79ac to 26c9b6e Compare December 6, 2024 09:46
@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

@bjorn3 bjorn3 marked this pull request as draft December 6, 2024 09:48
bjorn3 added 6 commits December 6, 2024 13:40
@bjorn3
Make the wasm_c_abi future compat warning a hard error
10a3850 
This is the next step in getting rid of the broken C abi for
wasm32-unknown-unknown.
@bjorn3
Avoid using make_direct_deprecated() in extern "ptx-kernel"
79305eb 
This method will be removed in the future as it produces a broken ABI
that depends on cg_llvm implementation details. After this PR
wasm32-unknown-unknown is the only remaining user of
make_direct_deprecated().
@bjorn3
Restore previous ABI for f_single_u8_arg
7f69c46
@bjorn3
Merge branch 'wasm_c_abi_lint_hard_error'
d91db3a
@bjorn3
Merge branch 'fix_ptx_kernel_abi'
c0b76a2
@bjorn3
Remove all support for wasm's legacy ABI
16e660d
@bjorn3 bjorn3 force-pushed the remove_wasm_legacy_abi branch from 26c9b6e to 16e660d Compare December 6, 2024 13:42
@daxpedda
Copy link
Contributor

#129630 needs to be reverted or adjusted as well.

@bjorn3
Copy link
Member Author

bjorn3 commented Dec 16, 2024

Removed the section in question.

@bjorn3 bjorn3 mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

@workingjubilee workingjubilee

Labels
A-ABI Area: Concerning the application binary interface (ABI) has-merge-commits PR has merge commits, merge with caution. O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
6 participants
@bjorn3 @rustbot @daxpedda @alexcrichton @cjgillot @workingjubilee