-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword resolve errors caused by likely missing crate in dep tree #133154
base: master
Are you sure you want to change the base?
Conversation
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only suggest Cargo-specific stuff if rustc_session::utils::was_invoked_from_cargo()
Apparently that detection checks for //@ revisions: only-rustc cargo-invoked
//@[only-rustc] unset-rustc-env:CARGO_CRATE_NAME
//@[cargo-invoked] rustc-env:CARGO_CRATE_NAME=foo which is... clever, almost too clever. |
``` error[E0432]: unresolved import `some_novel_crate` --> file.rs:1:5 | 1 | use some_novel_crate::Type; | ^^^^^^^^^^^^^^^^ use of unresolved module or unlinked crate `some_novel_crate` ```
On resolve errors where there might be a missing crate, mention `cargo add foo`: ``` error[E0433]: failed to resolve: use of unresolved module or unlinked crate `nope` --> $DIR/conflicting-impl-with-err.rs:4:11 | LL | impl From<nope::Thing> for Error { | ^^^^ use of unresolved module or unlinked crate `nope` | = help: if you wanted to use a crate named `nope`, use `cargo add nope` to add it to your `Cargo.toml` ```
3aefa86
to
68af421
Compare
This comment has been minimized.
This comment has been minimized.
6ad26a1
to
54856b5
Compare
This comment has been minimized.
This comment has been minimized.
54856b5
to
6a27b7f
Compare
This comment has been minimized.
This comment has been minimized.
6a27b7f
to
f4ed406
Compare
The Miri subtree was changed cc @rust-lang/miri |
f4ed406
to
fd5db02
Compare
Reword label and add
help
:Fix #133137.