controllers/krate/delete: Send deletion notification email after successful deletion #10265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
force-pushed
the
crate-deletion-email
branch
from
a3a7a8a to
1e50d69
Compare
LawnGnome
approved these changes
Dec 27, 2024
| format!( | ||
| "Hi {}, | ||
|
|
||
| this is a confirmation email for the deletion of your \"{}\" crate. |
There was a problem hiding this comment.
Wording tweak (feel free to ignore it if you want, but in that case let's at least capitalise the first letter):
Suggested change
| this is a confirmation email for the deletion of your \"{}\" crate. | |
| Your \"{}\" crate has been deleted, per your request. |
Comment on lines
+121
to
+132
| let email_future = async { | ||
| if let Some(recipient) = user.email(&mut conn).await? { | ||
| let email = CrateDeletionEmail { | ||
| user: &user.gh_login, | ||
| krate: &crate_name, | ||
| }; | ||
|
|
||
| app.emails.send(&recipient, email).await? | ||
| } | ||
|
|
||
| Ok::<_, anyhow::Error>(()) | ||
| }; |
There was a problem hiding this comment.
Curiosity, rather than any actual change required: was there a reason for doing this as an async block instead of an async fn?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part two of #9352 (comment) by sending a notification email to the owner when a crate is getting deleted.