Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle docs.rs in build.rs #90

Merged
merged 1 commit into from
Dec 14, 2023
Merged

handle docs.rs in build.rs #90

merged 1 commit into from
Dec 14, 2023

Conversation

DerZade
Copy link
Contributor

@DerZade DerZade commented Dec 13, 2023

This PR fixes #45

Handle docs.rs environment in dav1d-sys custom build script, like suggested in the docs.rs docs.

As far as I can tell, the build script does not add any functionality visible in the docs, so it should be possible to simply skip it in docs.rs build environments.

Copy link
Member

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Thank you

@sdroege sdroege merged commit 52409b2 into rust-av:master Dec 14, 2023
2 checks passed
@DerZade DerZade deleted the fix-docs-rs branch December 14, 2023 10:43
@DerZade
Copy link
Contributor Author

DerZade commented Dec 14, 2023

Thank you for merging this so quickly ❤️
Are there any plans for when the next release will be? No hurry or anything, just asking out of curiosity 🙈

@lu-zero
Copy link
Member

lu-zero commented Dec 14, 2023

Probably I can cut a point release this weekend.

@fintelia
Copy link

fintelia commented Jan 3, 2024

Friendly ping to publish a new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs are not failing to find dav1d library
4 participants