Ignore addrsig sections corrupted by strip #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removing symbols, the indices in .llvm_addrsig also needs to be updated, but binutils is not aware of this and leaves the table in a corrupt state. Use the same test as what LLD uses to reject potentially corrupted addrsig sections. Unfortunately, testing this seems tricky. While producing a file with OOB addrsig index is not hard, it's hard to consistently trigger a segfault with that access. Signed-off-by: Tatsuyuki Ishi <[email protected]>
ishitatsuyuki
force-pushed
the
icf-workaround
branch
from
d2eb607 to
fede4a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing symbols, the indices in .llvm_addrsig also needs to be updated, but binutils is not aware of this and leaves the table in a corrupt state.
Use the same test as what LLD uses to reject potentially corrupted addrsig sections.
Unfortunately, testing this seems tricky. While producing a file with OOB addrsig index is not hard, it's hard to consistently trigger a segfault with that access.
Signed-off-by: Tatsuyuki Ishi [email protected]
Closes #1174