Engine work #61

rudzen · 2023-03-24T23:20:46Z

Stabilization towards better support for creating a chess engine with ChessLib

- Better use of MemoryMarshal - Replaces some home-brew functionality with new dotnet 7 equivalent - Fixed a few sonar warnings - Added [SkipLocalsInit] where appropriate - Updated dependencies: - Microsoft.Extensions.ObjectPool 6.0.10 -> 7.0.0 - ZString 2.4.4 -> 2.5.0 - DryIoc 5.2.2 -> 5.3.1 - Microsoft.Extensions.Caching.Memory 6.0.1 -> 7.0.0 - Microsoft.Extensions.Configuration 6.0.1 -> 7.0.0 - Microsoft.Extensions.Configuration.EnvironmentVariables 6.0.1 -> 7.0.0 - Microsoft.Extensions.Configuration.Json 6.0.0 -> 7.0.0

- Added some more helper functions to IPosition - Fixed a UCI bug with options in regards to bool values - Updated dependencies - Added some static Create() factory methods to Score - Updated SearchParameters slightly - Minor update to HashTable<T> - Clarified some methods in KpkBitBase

- Renamed some TT related stuff - Fixed minor issue with Player ToString(....) - Added Position.Set() tests for code - to be used with endgame setup

- ExtMove -> ValMove - Added RootMove to act as easy use of list of moves - IPieceValue -> IValues - PieceValues -> DefaultPieceValues - Move struct now readonly

- Added AddChessLib() IServiceCollection extension - More types are now more friendly towards IoC in general - Any other developmental changes can be observed through the unit tests - Improved use of PolyglotBook, Blockage - Added IOptions usage for TT - Added PolyglotBook injectable factory with IOptions injected for base path - Perft tests that takes a long time is now disabled in debug mode - Perft time improved.. from ~3.2-3.4 seconds to ~3.0 seconds for start pos d=6 - Updated WebApi demo app

- Fixed a few nullable things - Corrected a few var names

- TT can now be created with 0 size if it is not needed

- added PieceType struct - fixed a validation bug which would allow a fen to be detected as faulty - renamed some "Castleling" stuff to "Castle" - removed some redundant stuff for project files - removed build timestamp from perft app - updated appsettings.json for perft app

- Player -> Color (to eliminate confusing semantics) - Added CPM - Update PGN parsing - Add PieceType type - Add CastleSide type - Fix a couple of variable namings - Added a zobrist hash test - Expanded HashKey a bit to be more flexible

…ion loading

src/web-api/Rudzoft.ChessLib.WebApi/Services/MoveGeneratorService.cs

+
+    public IEnumerable<string> GenerateMoves(MoveQuery parameters)
+    {
+        _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", parameters.Fen, parameters.Types, parameters.Mode);


To fix the problem, we need to sanitize the parameters.Fen input before logging it. This can be done by removing any new line characters from the input to prevent log forging. We can use the String.Replace method to achieve this. The best way to fix the problem without changing existing functionality is to modify the logging statement to sanitize the parameters.Fen input.

src/web-api/Rudzoft.ChessLib.WebApi/Services/MoveGeneratorService.cs

+
+    public IEnumerable<string> GenerateMoves(MoveQuery parameters)
+    {
+        _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", parameters.Fen, parameters.Types, parameters.Mode);


To fix the problem, we need to sanitize the user input before logging it. Specifically, we should remove any new line characters from the user input to prevent log forging. This can be done using the String.Replace method to replace new line characters with an empty string. We will apply this sanitization to the parameters.Types before it is logged.

src/web-api/Rudzoft.ChessLib.WebApi/Services/MoveGeneratorService.cs

+
+    public IEnumerable<string> GenerateMoves(MoveQuery parameters)
+    {
+        _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", parameters.Fen, parameters.Types, parameters.Mode);


To fix the problem, we need to sanitize the user input before logging it. Since the log entries are plain text, we should remove any new line characters from the user input to prevent log forging. This can be done using the String.Replace method to replace new line characters with an empty string.

We will modify the GenerateMoves method in the MoveGeneratorService class to sanitize the parameters.Fen, parameters.Types, and parameters.Mode before logging them.

rudzen added 21 commits February 10, 2023 17:39

Fixed minor formatting etc.

e61fb7a

Update copyright year

543d49d

Updated tables etc

f266641

Minor refactor

f6919fd

- Renamed some TT related stuff - Fixed minor issue with Player ToString(....) - Added Position.Set() tests for code - to be used with endgame setup

Fixed unintended non-cleared span for piece validation

acd7091

Updated some types to be more clear

c16f3b4

- ExtMove -> ValMove - Added RootMove to act as easy use of list of moves - IPieceValue -> IValues - PieceValues -> DefaultPieceValues - Move struct now readonly

Modernized Perft application

6a779d2

HiResTimer no longer computes delay if never going to be needed

150faf6

Updated KillerMoves to jagged array

b0082a8

Various minor code updates

7408832

Improved HiResTimer a bit

46a16d6

Added move list object pool as IoC object

2f3cca9

- Fixed a few nullable things - Corrected a few var names

PositionValidator can now be controlled through IoC

3d48a7c

Minor update to PieceSquareEventArgs

9a7a947

Update State use a bit + added missing properties from IGame

bbddc16

Refactorings

00455d7

Nullability warnings fixed + minor pos validator fix

9d369f9

Fix xunit serializaton fatal error

839f542

rudzen self-assigned this Mar 25, 2023

rudzen added the enhancement New feature or request label Mar 25, 2023

rudzen added 7 commits March 26, 2023 19:47

Added basic PGN file parser library

6c57c0c

Update reg ex pgn parser

0b50b99

Fix using old sample pgn

eb3164c

Added basic non-regex pgn parser

0ac7a06

Added simple SAN to move converter

20b3ee1

Added notational move converter

00f86f7

Accumative minor code updates

de0188b

- TT can now be created with 0 size if it is not needed

rudzen added 15 commits March 2, 2024 17:54

simplify move generator a bit

c653dc9

simplify en-passant setup when parsing fen

c58caab

simplify board structure

7c97a7e

updates

1fe5571

- added PieceType struct - fixed a validation bug which would allow a fen to be detected as faulty - renamed some "Castleling" stuff to "Castle" - removed some redundant stuff for project files - removed build timestamp from perft app - updated appsettings.json for perft app

added Peter Jones' perft tests

e4583c3

Semi-major update:

abaea7d

- Player -> Color (to eliminate confusing semantics) - Added CPM - Update PGN parsing - Add PieceType type - Add CastleSide type - Fix a couple of variable namings - Added a zobrist hash test - Expanded HashKey a bit to be more flexible

simplify bitboard static ctor a bit

5285b3a

added methodimpl attributes to Board and updated File

4c327fd

remove redundant method call when updating board position

9946645

SetupPieces uses correct types for rank and file

0a0010f

added more methodimpl to position

86cc2f1

update akka version

4fa0f20

fix for updating File size

6737232

update location of perft + using akka host

d7b7650

re-arrange src files structure in a more vertical friendly way

790eee6

rudzen force-pushed the engine_work branch from 963a9ab to 790eee6 Compare June 27, 2024 21:42

rudzen and others added 13 commits June 27, 2024 23:42

Update test.yml

6174d6d

Update publish.yml

4cf3bc6

link some files

28bdad4

various minor issues and warnings fixed

298ae5c

removed attribute from exceptions

0ac016b

fix a position assert

7833774

fix several warnings and problems with projects + simplify configurat…

7f23f1d

…ion loading

tests no longer configures options for configuration

6171174

remove duplicate package version declaration

0ecf070

simplify some perft functionality a bit

96ba919

simplify move tests a bit

98120fc

simplify bitboard to string method a bit

42d4f6f

removed redundant project settings for perft project

f43af73

github-advanced-security bot found potential problems Nov 25, 2024

View reviewed changes

@@ -11,3 +11,4 @@
                 {
-                    _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", parameters.Fen, parameters.Types, parameters.Mode);
+                    var sanitizedFen = parameters.Fen.Replace(Environment.NewLine, "").Replace("\n", "").Replace("\r", "");
+                    _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", sanitizedFen, parameters.Types, parameters.Mode);

@@ -11,3 +11,4 @@
                 {
-                    _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", parameters.Fen, parameters.Types, parameters.Mode);
+                    var sanitizedTypes = parameters.Types.Replace(Environment.NewLine, "").Replace("\n", "").Replace("\r", "");
+                    _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", parameters.Fen, sanitizedTypes, parameters.Mode);

@@ -11,3 +11,6 @@
                 {
-                    _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", parameters.Fen, parameters.Types, parameters.Mode);
+                    var sanitizedFen = parameters.Fen.Replace(Environment.NewLine, "").Replace("\n", "").Replace("\r", "");
+                    var sanitizedTypes = parameters.Types.Replace(Environment.NewLine, "").Replace("\n", "").Replace("\r", "");
+                    var sanitizedMode = parameters.Mode.Replace(Environment.NewLine, "").Replace("\n", "").Replace("\r", "");
+                    _logger.LogInformation("Generating moves. fen={Fen},type={Type},mode={Mode}", sanitizedFen, sanitizedTypes, sanitizedMode);

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Engine work #61

Engine work #61

rudzen commented Mar 24, 2023 •

edited

Loading

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Engine work #61

Are you sure you want to change the base?

Engine work #61

Conversation

rudzen commented Mar 24, 2023 • edited Loading

rudzen commented Mar 24, 2023 •

edited

Loading