This repository has been archived by the owner on Oct 6, 2024. It is now read-only.
Upgrade to django42 #1341
Merged
Upgrade to django42 #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntry-webpack, rm djangocms helpers
sebgrebe
commented
Apr 3, 2024
| ) | ||
| email.attach_alternative(html_msg, "text/html") |
There was a problem hiding this comment.
this shouldn't work as it's not EmailMultiAlternatives
| @@ -0,0 +1,48 @@ | |||
| # Generated by Django 3.2.15 on 2024-03-31 14:57 | |||
There was a problem hiding this comment.
django 3.2? Can this be removed?
There was a problem hiding this comment.
Same with localgroups
eahub/tests/e2e/test_signup.py
Outdated
| @@ -10,6 +10,9 @@ def test_signup(self): | |||
| user_email = "[email protected]" | |||
| user_password = "Wa4@;fh>A/~W#6SH" | |||
|
|
|||
| print("LIVE SERVER URL") | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes because of upgrade to Django 4.2:
django_pwned_passwordswithpwned-passwords-djangoas the other was no longer working after django upgradecrispy-bootstrap3(needed with v2 of Django-crispy-forms)DateRangeFilterimportrecaptchapackagedjango.urls.re_pathinstead ofurl(depracated)last_name, notnamepytest.ini(selenium was failing after upgrade because it was missing)django-cmshelperssend_emailmethod (no longer maintained) with Django's default methodload_seed_dataSocialAppif in local or test environment to ensure that website can loadprovide_login_urltemplate tag was throwing an error. Came after upgrading to 0.60Changes to functionality: Groups page
table.jsas it has outdated JS dependencies, which are a pain to keep updatedtables.jsneeds to be brought back or some other, new code usedOther changes
NODE_OPTIONS=--openssl-legacy-providertonpm run build, which is needed with node18django-sluggableto specific commit in requirements.in (not .txt)