pgp: adds support for signing with an HSM held key #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/hsm-support
branch
3 times, most recently
from
349da14 to
78f4984
Compare
|
Needs a changelog entry |
baloo
force-pushed
the
baloo/hsm-support
branch
from
78f4984 to
0e36522
Compare
dralley
reviewed
Nov 8, 2024
| @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Added `zstdmt` feature which sets zstd compression to use all available cores. | |||
| - Added feature flags for every compression algorithm to support disabling unused ones. | |||
| - Bump `pgp` to 0.14.0 | |||
| - Added support for signing with a key held in an HSM | |||
There was a problem hiding this comment.
This should go in an ### Added section
There was a problem hiding this comment.
And probably so should the first two items tbh.
baloo
force-pushed
the
baloo/hsm-support
branch
from
0e36522 to
a380e6f
Compare
baloo
force-pushed
the
baloo/hsm-support
branch
from
a380e6f to
16f19b6
Compare
dralley
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows for the private key to be kept in an HSM/TPM/smartcard and protect it.
📜 Checklist
--all-featuresenabled