Speed up hole nesting #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With large polygons and lots of holes, this can be _extremely_ slow, so I've converted it to Rust and done some optimization on the contains raycast. For the problematic shapefile that exposed this, processing was a bit under 50x slower than with the Rust code.
If there's a multipolygon with more than one polygon and a hole that doesn't fit in any of them, the Elixir version will attach the hole to the last polygon.
This doesn't actually seem to matter, but it's good hygiene
This improves the runtime of the problematic shapefile by another third.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With large polygons and lots of holes, this can be extremely slow, so
I've converted it to Rust and done some optimization on the contains
raycast. For the problematic shapefile that exposed this, processing
was a bit under 50x slower than with the Rust code.