Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: sidebar #138

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from
Open

Doc: sidebar #138

wants to merge 5 commits into from

Conversation

Wolfr
Copy link
Collaborator

@Wolfr Wolfr commented Jun 1, 2020

Implement a sidebar layout for the docs.

This PR can be merged, this is already an improvement in the right direction.

  • Mobile menu has been tested

To be fixed:

  • Blog children are showing in the sidebar
  • The third nav level (e.g. guide/installation/installation) is not showing in the sidebar

@vercel
Copy link

vercel bot commented Jun 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jakobrosenberg/routify-2020/dpc9pjby0
✅ Preview: https://routify-2020-git-docssidebar.jakobrosenberg.now.sh

@Wolfr
Copy link
Collaborator Author

Wolfr commented Jun 1, 2020

Question @jakobrosenberg , if I set <!-- routify:options index=false --> on the blog pages, they disappear entirely. Can you check what is going on?

@Wolfr
Copy link
Collaborator Author

Wolfr commented Jun 1, 2020

I've now set it up to use <svelte:self> but I could use some help @jakobrosenberg .

  • Only show 3rd level nav when you are actually in the 2nd level item, otherwise the nav gets too busy
  • Show the icons for Discord etc. (I need to pass the meta but I don't know how, the code is working in the commented out code at the bottom of NavItems.svelte, but that tree is not “recursive”)

@www-chique
Copy link
Contributor

Hey, just wanted to show these. Ignore me if this is not an issue.
Browser: Firefox latest

  1. Dual scrollbars on responsive / smaller screen.
    image

  2. With the menu opened, and scrolling down, the "X" close button scrolls along with the body. Would be better if it doesn't scroll.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants