-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discovered HVAC and PRESET options #1177
Conversation
This commit adds the HVAC Action Set and Preset Set that I've discovered my Bödenwarme Underfloor Heating thermostat to be using as detailed here: #1175
These are the actions and modes as reported by the Magnum smart wifi thermostat: https://www.magnumheating.com/product/remote-control/
Branch rebased. Would be nice to see this in the next update as I now understand there are others with similar issues that could be fixed with these modes added :) |
Add HVAC mode and action sets for climate entities
I've pulled in some very similar work by @RutgerKe to try and relieve PR reviews. |
Will this or the the similar PR be reviewed and merged anytime soon? I appreciate a more dynamic solution was suggested by @rospogrigio at once point but we're four months on and it does not seem the time and motivation has been found to do this yet (not a criticism, I very well know what it's like to not find time or motivation to pursue an idea sometimes!) so I'd have thought just allowing these additional options to be merged in would be a good solution whilst you have folk contributing them :) |
Please, please just let this be merged. It's such a simple change. I know there's hope for a more dynamic solution, but it's been nearly two years now. Please just let us add these things in. It'll be wonderful to add the dynamic stuff later, but does that actually stop things like this being merged? |
Ooo, thank you for approval. I see the two workflows have succeeded but I'm not sure what the final |
Thank you muchly, any chance of a release so HACS can spot the update? :) |
Following up from my previous comment, I still would very much like a release done, but I'd suggest reviewing (and hopefully merging) my latest PR first, which combines a few more HVAC mode PRs :) #1793 |
This commit adds the HVAC Action Set and Preset Set that I've discovered my Bödenwarme Underfloor Heating thermostat to be using as detailed here: #1175