Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovered HVAC and PRESET options #1177

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Add discovered HVAC and PRESET options #1177

merged 6 commits into from
Sep 13, 2024

Conversation

apbarratt
Copy link

This commit adds the HVAC Action Set and Preset Set that I've discovered my Bödenwarme Underfloor Heating thermostat to be using as detailed here: #1175

This commit adds the HVAC Action Set and Preset Set that I've discovered my Bödenwarme Underfloor Heating thermostat to be using as detailed here: #1175
@apbarratt
Copy link
Author

Branch rebased. Would be nice to see this in the next update as I now understand there are others with similar issues that could be fixed with these modes added :)

Add HVAC mode and action sets for climate entities
@apbarratt
Copy link
Author

I've pulled in some very similar work by @RutgerKe to try and relieve PR reviews.
@rospogrigio Please do let me know if there are some similar PRs you'd like me to pull in, assuming they are of a similar nature to this, they should merge in nicely without conflicts and you'll have a single PR to review instead of several similar ones :)

@apbarratt
Copy link
Author

Will this or the the similar PR be reviewed and merged anytime soon? I appreciate a more dynamic solution was suggested by @rospogrigio at once point but we're four months on and it does not seem the time and motivation has been found to do this yet (not a criticism, I very well know what it's like to not find time or motivation to pursue an idea sometimes!) so I'd have thought just allowing these additional options to be merged in would be a good solution whilst you have folk contributing them :)
If you have a list of similar PRs that I could work through to create a single new options PR, I'd be more than happy to spend a little time combining them together for a single review :)

@apbarratt
Copy link
Author

Please, please just let this be merged. It's such a simple change. I know there's hope for a more dynamic solution, but it's been nearly two years now. Please just let us add these things in. It'll be wonderful to add the dynamic stuff later, but does that actually stop things like this being merged?

@apbarratt
Copy link
Author

Ooo, thank you for approval. I see the two workflows have succeeded but I'm not sure what the final ci one is waiting for, I can't see a workflow file by that name so not sure what it is. Can you tell I'm not a devops guy by trade? 😅

@rospogrigio rospogrigio merged commit 1da7b31 into rospogrigio:master Sep 13, 2024
2 checks passed
@apbarratt apbarratt deleted the patch-1 branch September 13, 2024 13:07
@apbarratt
Copy link
Author

Thank you muchly, any chance of a release so HACS can spot the update? :)

@apbarratt
Copy link
Author

Following up from my previous comment, I still would very much like a release done, but I'd suggest reviewing (and hopefully merging) my latest PR first, which combines a few more HVAC mode PRs :) #1793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants