Skip to content
This repository has been archived by the owner on Aug 11, 2023. It is now read-only.

fix concurrent service calls, add test #266

Closed

Conversation

LeroyR
Copy link
Contributor

@LeroyR LeroyR commented Feb 23, 2018

Test/fix attempt for #261

@LeroyR LeroyR changed the title fix cuncurrent service calls, add test fix concurrent service calls, add test Feb 23, 2018
@msmcconnell
Copy link

msmcconnell commented Feb 23, 2018

Thanks for taking a shot at that Issue.
I tried running the test but I still got some mismatched result values.

Feb 23, 2018 11:04:52 AM org.ros.internal.node.RosoutLogger info
    INFO: 
    Request: 0+0 Result: 0

    Feb 23, 2018 11:04:52 AM org.ros.internal.node.RosoutLogger info
    INFO: 
    Request: 2+2 Result: 2

    Feb 23, 2018 11:04:52 AM org.ros.internal.node.RosoutLogger info
    INFO: 
    Request: 6+6 Result: 8

    Feb 23, 2018 11:04:52 AM org.ros.internal.node.RosoutLogger info
    INFO: 
    Request: 4+4 Result: 12


    Feb 23, 2018 11:04:52 AM org.ros.internal.node.RosoutLogger info
    INFO: 
    Request: 9+9 Result: 16

Were you able to run this test successfully?
Maybe one of the regular contributors can provide some insights on what your solution is failing to address.

@jubeira
Copy link

jubeira commented Feb 23, 2018

Thanks for kicking this off @LeroyR @msmcconnell.

I'll take a look when I have some time; apparently this could be a first step but something else is missing there.

/cc @drigz

@LeroyR
Copy link
Contributor Author

LeroyR commented Feb 25, 2018

Yes, it just randomly worked once. I think there is currently no way to preserve ordering if we call the service multiple times with the same client. Was searching for a issue we had where sometimes no handler was registered, my branch had debug prints that (of course) then 'fixed' the ordering

close this PR

@LeroyR LeroyR closed this Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants