Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

make scripts python3 compatible #45

Open
wants to merge 1 commit into
base: kinetic
Choose a base branch
from

Conversation

LeroyR
Copy link

@LeroyR LeroyR commented Sep 19, 2019

#44

@fmessmer
Copy link

fmessmer commented Jan 15, 2021

@LeroyR
how do you deal with the fact that the env-hooks still call python explicitly?
because in ubuntu focal, there is no such executable but only python2 and python3...
so for this to work you'll have to install python-is-python3 or something or create the python symlink yourself...

@LeroyR
Copy link
Author

LeroyR commented Jan 15, 2021

Well this branch is called "kinetic" so we dont.

If this comes up (guess when we update) we will just patch the env hooks call python3 directly. You could also check if "python" exists and otherwise use python3 inside the scripts.

@fmessmer
Copy link

Well this branch is called "kinetic" so we dont.

If this comes up (guess when we update) we will just patch the env hooks call python3 directly. You could also check if "python" exists and otherwise use python3 inside the scripts.

ok...I was just curious as we at mojin-robotics currently try to use rosjava in noetic
we made our kinetic branch multi-distro/python-version-compatible
it works with python-is-python3 installed, but I wanted to get rid of that...

are you using rosjava in noetic or still under kinetic?

@LeroyR
Copy link
Author

LeroyR commented Jan 15, 2021

We use melodic with our forks of rosjava_ mostly to change the maven repository path to be compatible with everything else on our CI and maven projects. You may habe more luck with our forks if you run into any troubles.

@fmessmer
Copy link

We use melodic with our forks of rosjava_ mostly to change the maven repository path to be compatible with everything else on our CI and maven projects. You may habe more luck with our forks if you run into any troubles.

thanks, except for the workaround for the missing python executable I have all I need so far....but I will compare with your forks...
in melodic you can still rely on python executable being symlinked against either python2 or python3...this is different in ubuntu focal (for noetic)

@fmessmer
Copy link

fmessmer commented Jan 18, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants