Skip to content
This repository has been archived by the owner on Jan 14, 2023. It is now read-only.

build.gradle to publish both sources and javadoc #16

Open
wants to merge 1 commit into
base: indigo
Choose a base branch
from

Conversation

gb96
Copy link

@gb96 gb96 commented Mar 27, 2018

Current gradle build only publishes compiled Java classes to maven repository.

It helps java developers if sources and javadoc are also published as most Java IDEs can leverage those to provide better assistance (particularly during run-time debugging, static code analysis, and also for developers learning new api).

I realise there is currently little or no javadoc tags in the generated java sources, however in future it might be possible for genjava to include some additional information via those tags.

Current gradle build only publishes compiled Java classes to maven repository.
It helps java developers if sources and javadoc are also published as most Java IDEs can leverage those to provide better assistance (particularly during run-time debugging, static code analysis, and also for developers learning new api)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@jubeira
Copy link

jubeira commented Mar 27, 2018

Hi @gb96, thanks for the PR.

Please correct me if I'm mistaken, but genjava is mainly used to generate the artifacts for messages and services. Is that the documentation you would like to have in the JAR files?

That being said, I think it could be a good improvement; we should cherrypick the changes to Kinetic as well. @drigz any thoughts?

@drigz
Copy link
Member

drigz commented Mar 27, 2018

No comments from my side - I haven't been using the Gradle build much.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants