Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Commit

Permalink
[master_chooser] bugfix launch mode for the master chooser.
Browse files Browse the repository at this point in the history
The singleTask launch mode now causes startActivityForResult to immediately cancel
and return. Even though the master chooser would continue, any subsequent calls to finish
would not return any meaningful activity result because it had already returned a cancelled
result as it started.

http://stackoverflow.com/questions/8960072/onactivityresult-with-launchmode-singletask

This fixes #231. It may also have something to do with rosjava/android_remocons#61.
  • Loading branch information
stonier committed Feb 24, 2015
1 parent 79b2960 commit f8ae170
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion android_10/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<activity
android:name="org.ros.android.MasterChooser"
android:label="@string/app_name"
android:launchMode="singleTask"/>
android:launchMode="standard"/>

<service android:name="org.ros.android.NodeMainExecutorService"
tools:ignore="ExportedService">
Expand Down

1 comment on commit f8ae170

@stonier
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't worked out why this is suddenly an issue though...something new in the android tooling or perhaps it wasn't getting started like this previously.

Please sign in to comment.