Time #79
Time #79
Conversation
|
Please avoid commit messages that fail to describe changes made. You can do |
|
It seems like your PR includes a binary file that should have been gitignored. Please add |
|
We ask that all cog filenames end in |
|
|
||
| def setup(bot): | ||
| bot.add_cog(TimeConverter(bot)) | ||
| å |
There was a problem hiding this comment.
This line seems like a mistake. Please remove it 🙂
| @commands.command | ||
| async def convert(cls, argument): | ||
| args = argument.lower() | ||
| matches = re.findall(time_regex, args) |
There was a problem hiding this comment.
Is time_regex defined somewhere?
| time = 0 | ||
| for key, value in matches: | ||
| try: | ||
| time += time_dict[value] * float(key) |
| def __init__(self, bot): | ||
| self.bot = bot | ||
|
|
||
| @commands.command |
There was a problem hiding this comment.
I believe this should be @commands.command(). Have you tested this code?
| from discord.ext import commands | ||
|
|
||
|
|
||
| class TimeConverter(commands.Cog): |
There was a problem hiding this comment.
For the sake of consistency, could you change the name of this class to TimeCog and change the file name to correspond to it? Thanks!
Time converter