Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export tinyxml cmake target #27

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Conversation

briansoe66
Copy link

Rewrite tinyxml_cmakelists.txt to export cmake target.
FindTinyXML.cmake and enforce-use-stl.patch are no longer needed.

Original method to use tinyxml:

list(APPEND CMAKE_MODULE_PATH path-to-FindTinyXML.cmake)
find_package(TinyXML REQUIRED)
target_include_directories(my-target PUBLIC ${TinyXML_INCLUDE_DIRS})
target_link_libraries(my-target PUBLIC ${TinyXML_LIBRARIES})
add_definitions(TIXML_USE_STL)

New method to use tinyxml:

find_package(tinyxml REQUIRED)
target_link_libaries(my-target PUBLIC tinyxml::tinyxml)

NOTE: TinyXML_INCLUDE_DIRS and TinyXML_LIBRARIES are no longer defined. They probably should be defined, for backward compatibility, but I don't know how to do this.

Use find_package(tinyxml) + target_link_libaries(tinyxml::tinyxml).
FindTinyXML.cmake and enforce-use-stl.patch are no longer needed.

Signed-off-by: Brian Soe <[email protected]>
@briansoe66 briansoe66 changed the title export tinyxml target export tinyxml cmake target Dec 31, 2021
@gbiggs
Copy link
Member

gbiggs commented Feb 19, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@gbiggs
Copy link
Member

gbiggs commented Feb 21, 2022

@briansoe66 Can you please take a look at the CI output and correct the error that's occurring? I get the same error when I build it locally.

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants