Cleanup services implementation #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
7 tasks
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/cleanup_services
branch
from
4bbfd3c to
cbb8e16
Compare
Yadunund
merged commit e181435
into
francocipollone/service_support_via_queryable
5 checks passed
|
Thanks! 🚀 |
Yadunund
added a commit
that referenced
this pull request
Dec 28, 2023
* Rely on channels for sending requests Signed-off-by: Yadunund <[email protected]> * Revert to callback for client with fixes Signed-off-by: Yadunund <[email protected]> * Cleanup service cb Signed-off-by: Yadunund <[email protected]> * Style Signed-off-by: Yadunund <[email protected]> * Cleanup comments Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]>
Yadunund
added a commit
that referenced
this pull request
Jan 12, 2024
* Adds base support for services. Signed-off-by: Franco Cipollone <[email protected]> * Addresses Yadu's comments. Signed-off-by: Franco Cipollone <[email protected]> * Addresses Yadu's comments. Signed-off-by: Franco Cipollone <[email protected]> * Fixes memory leak. Signed-off-by: Franco Cipollone <[email protected]> * Removes unnecessary declaration. Signed-off-by: Franco Cipollone <[email protected]> * Cleanup services implementation (#88) * Rely on channels for sending requests Signed-off-by: Yadunund <[email protected]> * Revert to callback for client with fixes Signed-off-by: Yadunund <[email protected]> * Cleanup service cb Signed-off-by: Yadunund <[email protected]> * Style Signed-off-by: Yadunund <[email protected]> * Cleanup comments Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> * Use anynomous space instead of static functions. Signed-off-by: Franco Cipollone <[email protected]> * Fix style. Signed-off-by: Franco Cipollone <[email protected]> * Use zero_allocate where needed. Signed-off-by: Franco Cipollone <[email protected]> * Use a scope_exit to drop the keystr. This just makes sure we always clean it up. Signed-off-by: Chris Lalancette <[email protected]> * Rename find_type_support to find_message_type_support. Signed-off-by: Chris Lalancette <[email protected]> * Add error checking into ros_topic_name_to_zenoh_key Signed-off-by: Chris Lalancette <[email protected]> * Make sure to always free response_bytes. Signed-off-by: Chris Lalancette <[email protected]> * Remove unnecessary TODO comment. Signed-off-by: Chris Lalancette <[email protected]> * Remember to free request_bytes. Signed-off-by: Chris Lalancette <[email protected]> * Small change to take requests from the front of the deque. Signed-off-by: Chris Lalancette <[email protected]> * Initial work for attachments and sequence numbers. Signed-off-by: Chris Lalancette <[email protected]> * Add in error checking for getting attachments. Signed-off-by: Chris Lalancette <[email protected]> * More error checking for attachments. Signed-off-by: Chris Lalancette <[email protected]> * Further cleanup. Signed-off-by: Chris Lalancette <[email protected]> * Remove unnecessary (and incorrect) copy of sequence_number Signed-off-by: Chris Lalancette <[email protected]> * Style Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: Yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Yadu <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Yadunund
added a commit
that referenced
this pull request
Jan 12, 2024
* Adds base support for services. Signed-off-by: Franco Cipollone <[email protected]> * Addresses Yadu's comments. Signed-off-by: Franco Cipollone <[email protected]> * Addresses Yadu's comments. Signed-off-by: Franco Cipollone <[email protected]> * Fixes memory leak. Signed-off-by: Franco Cipollone <[email protected]> * Removes unnecessary declaration. Signed-off-by: Franco Cipollone <[email protected]> * Cleanup services implementation (#88) * Rely on channels for sending requests Signed-off-by: Yadunund <[email protected]> * Revert to callback for client with fixes Signed-off-by: Yadunund <[email protected]> * Cleanup service cb Signed-off-by: Yadunund <[email protected]> * Style Signed-off-by: Yadunund <[email protected]> * Cleanup comments Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> * Use anynomous space instead of static functions. Signed-off-by: Franco Cipollone <[email protected]> * Fix style. Signed-off-by: Franco Cipollone <[email protected]> * Use zero_allocate where needed. Signed-off-by: Franco Cipollone <[email protected]> * Use a scope_exit to drop the keystr. This just makes sure we always clean it up. Signed-off-by: Chris Lalancette <[email protected]> * Rename find_type_support to find_message_type_support. Signed-off-by: Chris Lalancette <[email protected]> * Add error checking into ros_topic_name_to_zenoh_key Signed-off-by: Chris Lalancette <[email protected]> * Make sure to always free response_bytes. Signed-off-by: Chris Lalancette <[email protected]> * Remove unnecessary TODO comment. Signed-off-by: Chris Lalancette <[email protected]> * Remember to free request_bytes. Signed-off-by: Chris Lalancette <[email protected]> * Small change to take requests from the front of the deque. Signed-off-by: Chris Lalancette <[email protected]> * Initial work for attachments and sequence numbers. Signed-off-by: Chris Lalancette <[email protected]> * Add in error checking for getting attachments. Signed-off-by: Chris Lalancette <[email protected]> * More error checking for attachments. Signed-off-by: Chris Lalancette <[email protected]> * Further cleanup. Signed-off-by: Chris Lalancette <[email protected]> * Remove unnecessary (and incorrect) copy of sequence_number Signed-off-by: Chris Lalancette <[email protected]> * Style Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: Yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Yadu <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes