Do not include service/client tracepoints for Jazzy #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
|
This fixes Jazzy builds. Feel free to not take this (or request changes) if you prefer another solution; I just wanted to propose a PR to fix what I broke 😁 |
|
Thanks @christophebedard! We've decided to leave the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #294
As reported on that PR (#294 (comment)), Jazzy builds are broken, because the service/client tracepoints do not exist on Jazzy:
rmw_client_init,rmw_send_request,rmw_take_request,rmw_send_response,rmw_take_response(added in Rolling in ros2/ros2_tracing#145).I added a generated header with some distro-specific
#defines based onros_environment, and then used it to exclude the service/client tracepoints on Jazzy.