-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add examples for how to use the new rclcpp::WaitSet classes #262
Conversation
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-05-21/14247/1 |
@wjwwood I just looked into the example code and it helped me quite a bit. I was wondering if you plan to finish this PR, it has been on hold since spring. If you do, it would be great to add the arguably more common use case of a node that is spinning and how to use a waitset inside the node to wait for input from another node. |
I want to, and now I might have the time, with help from others.
That's a good idea. These examples were really "does it work" more than "this is what I expect will happen in the wild". But we should improve them to be more like the latter.
Yes, these examples were just testing the waitset part, but how it might be used in a larger scope. |
Echoing Fred's request, I'm also wondering how you could transfer responsibility for a subscription from an executor to a waitset, especially when you don't control the executor (like in a component container). It's not even clear to me how to instantiate a static wait set with a single subscription – I would expect this to work, but it doesn't (in Foxy):
|
Closing in favor of #315 |
This is still WIP (not ready for review or comments).
Connects to ros2/rclcpp#1047