Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume pre-configured environment variables instead of setup script for Connext #651

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Assume pre-configured environment variables instead of setup script for Connext #651

wants to merge 1 commit into from

Conversation

nuclearsandwich
Copy link
Member

@nuclearsandwich nuclearsandwich commented Mar 30, 2022 •
edited
Loading

@clalancette reported these warnings showing up in the Windows builds:

WW> Asked to use Connext but the RTI env was not found at 'C:\Program Files\rti_connext_dds-5.3.1\resource\scripts\rtisetenv_x64Win64VS2017.bat'

The ROS 2 cookbook is setting environment variables used by rti_connext_dds_cmake_module and test_security. The Windows setup should check that those are set rather than overriding them with files found on the host.

@nuclearsandwich
Assume pre-configured environment variables instead of setup script f…
1cea665 
…or Connext.

The ROS 2 cookbook is setting environment variables used by
rti_connext_dds_cmake_module and test_security. The Windows setup should
check that those are set rather than overriding them with files found on
the host.
@nuclearsandwich nuclearsandwich self-assigned this Mar 30, 2022
@nuclearsandwich
Copy link
Member Author

nuclearsandwich commented Mar 30, 2022 •
edited
Loading

Rolling Build Status
Foxy Build Status
Galactic Build Status

clalancette
clalancette approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me assuming that CI comes back green on Rolling, Galactic, and Foxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@cottsay cottsay Awaiting requested review from cottsay cottsay will be requested when the pull request is marked ready for review cottsay is a code owner

Assignees

@nuclearsandwich nuclearsandwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuclearsandwich @clalancette