Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request:Make the isPathValid Service Configurable with Parameters #4756

Open
BCKSELFDRIVEWORLD opened this issue Nov 19, 2024 · 1 comment

Comments

@BCKSELFDRIVEWORLD
Copy link

Feature request

Feature description

Currently, the isPathValid service considers a path valid as long as the costs are not lethal. However, in many scenarios, users might need more flexibility in determining what constitutes a valid path. For instance, there might be cases where paths with costs above a certain threshold (but below lethal cost) should also be considered invalid.

To address this, I propose introducing a parameter that allows users to specify the threshold cost for path validity. This would make the service more adaptable to different use cases and improve its overall utility.

Proposed Feature:

  • Add a parameter to the isPathValid service that allows users to define the maximum allowable cost for a path to be considered valid.
@SteveMacenski
Copy link
Member

Seems reasonable to have a max cost parameter or in the service request itself. I think the service request having a field for the max, valid cost would be great & pretty easy contribution. @BCKSELFDRIVEWORLD can you submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants