Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for iterative graceful controller #624

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

mikeferguson
Copy link
Contributor

@mikeferguson mikeferguson commented Dec 13, 2024

@mikeferguson mikeferguson marked this pull request as ready for review December 13, 2024 18:24
@mikeferguson
Copy link
Contributor Author

mikeferguson commented Dec 14, 2024

TODO (after review and updates to underlying PR):

  • re-add initial_rotation
  • remove add_orientations
  • document in_place_collision_tolerance

Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Michael Ferguson <[email protected]>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending underlying PR.

Only thing would be to add in the migration guide that we adjusted some parameters and list just the changed parameters for folks to be aware of

Signed-off-by: Michael Ferguson <[email protected]>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeferguson a few additions:

  • You changed the defaults of the k/beta parameters, the new defaults should be updated in this table
  • In the migration guide, we should mention this (Pretty big) change
  • In the Navigation Plugins table, I'd add in omni as supported motion models (not just diff)

@mikeferguson
Copy link
Contributor Author

  • In the migration guide, we should mention this (Pretty big) change

Where in the migration doc do we want this? The Jazzy->K-turtle part, or are we planning to backport at all?

Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Michael Ferguson <[email protected]>
@SteveMacenski
Copy link
Member

Since it changes and removes parameters, it cannot be backported, so J->K

Signed-off-by: Michael Ferguson <[email protected]>
Signed-off-by: Michael Ferguson <[email protected]>
@mikeferguson
Copy link
Contributor Author

@SteveMacenski - added requested items - I think this ready for a final review

@SteveMacenski SteveMacenski merged commit 8945bbe into ros-navigation:master Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants