Move fixed navbars out of the way.

[ohryan]

When logged in to WordPress the navbar-fixed-top becomes covered by the WordPress admin bar. This CSS bumps it out of the way.

[retlehs]

We removed this when removing the option for a fixed navbar out of the box.
We want to remove as much Bootstrap specific things possible in Roots
instead of adding more.

I'd pull up the commit but I'm on the road

Sent from my iPhone

On Aug 29, 2014, at 2:52 PM, Ryan Neudorf [email protected] wrote:

When logged in to WordPress the navbar-fixed-top becomes covered by the

WordPress admin bar. This CSS bumps it out of the way.

You can merge this Pull Request by running

git pull https://github.com/ohryan/roots master

Or view, comment on, or merge it at:

#1143
Commit Summary

• Move fixed navbars out of the way.

File Changes

• M assets/less/components/_wp-classes.less
  https://github.com/roots/roots/pull/1143/files#diff-0 (5)

Patch Links:

• https://github.com/roots/roots/pull/1143.patch
• https://github.com/roots/roots/pull/1143.diff

—
Reply to this email directly or view it on GitHub
#1143.

[ohryan]

We want to remove as much Bootstrap specific things possible in Roots
instead of adding more.

I would expect roots to do things that help WordPress and Bootstrap play nice together. Unless you are planning on moving roots away from bootstrap?

[Foxaii]

It is our long term goal for Roots to become framework agnostic. That's why we've been removing tweaks like this for a while.

I'm not sure reintegrating such tweaks is open for debate but if it is:

1. We would need to make it clear that the tweak is Bootstrap specific code i.e place it in a separate file (it's not a WordPress class). And;
2. It would need to incorporate the Bootstrap variables for the navbar heights so that it does things right across the board.

[JulienMelissas]

@ohryan, eventually we'd like to have roots be front-end framework agnostic, which is why we're trying to keep bootstrap-specific commits out unless really necessary. You could totally post it up on the roots discourse.

edit: oops just saw @Foxaii's comment. Sorry for the redundancy.

[JulienMelissas]

@Foxaii, let me get back to your 2 points:

1. It might actually be a good idea to have a bootstrap-specific LESS file for these bootstrap changes. That could be a good place for the code in Move <main> and .sidebar markup out of PHP and into LESS #1090 to go, maybe
2. I'm pretty sure he's going off of the height of the wordpress admin navigation bar, and it wouldn't matter what height the bootstrap variables are

[ohryan]

It is our long term goal for Roots to become framework agnostic. That's why we've been removing tweaks like this for a while.

@Foxaii interesting, do you have a blog post or anything on this?

1. I'm pretty sure he's going off of the height of the wordpress admin navigation bar, and it wouldn't matter what height the bootstrap variables are

@JulienMelissas Right.

[JulienMelissas]

@ohryan there haven't been any official announcements or blog posts from the team as far as I can tell, but @retlehs mentioned it a while back somewhere on the roots form, as since then it's being coming up in various PR's, issues, and on the forum.

I think we're all still figuring out the best way to do it. I'm still trying to wrap my head around how I would even attempt to do it.

[Foxaii]

You can ignore point 2 in this instance. But certainly any other tweaks would need to reference the correct variables, where applicable.

Julien is right about the topic, nothing has been codified, it's just been mentioned here and there. We haven't written up a specific post about the future of Roots, but a vague roadmap probably wouldn't hurt.