🐛 Fix cell data type ref when showing row numbers

Closes #208
ronisbr · Jul 21, 2023 · dd5e008 · dd5e008
1 parent 739100b
commit dd5e008
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 7 deletions.
diff --git a/src/backends/text/print_table.jl b/src/backends/text/print_table.jl
@@ -248,7 +248,7 @@ function _print_table_data!(
                         # In this case, we need to process the cell to apply the
                         # correct alignment and highlighters before rendering
                         # it.
-                        cell_data = _get_element(ptable, rps.i_pt, jr)
+                        cell_data = _get_element(ptable, rps.i_pt, j)
 
                         cell_processed_str, cell_crayon = _process_data_cell_text(
                             ptable,

diff --git a/test/text_backend/issues.jl b/test/text_backend/issues.jl
@@ -1157,13 +1157,13 @@ end
 │ Row │     B │            A │
 │     │ Int64 │ AnsiTextCell │
 ├─────┼───────┼──────────────┤
-│   1 │     1 │            1 │
-│   2 │     2 │            2 │
-│   3 │     3 │            3 │
+│   1 │     1 │            1\e[0m │
+│   2 │     2 │            2\e[0m │
+│   3 │     3 │            3\e[0m │
 │  ⋮  │   ⋮   │      ⋮       │
-│  98 │    98 │           98 │
-│  99 │    99 │      99      │
-│ 100 │ 100   │          100 │
+│  98 │    98 │           98\e[0m │
+│  99 │    99 │      99     \e[0m │
+│ 100 │ 100   │          100\e[0m │
 └─────┴───────┴──────────────┘
                94 rows omitted
 """
@@ -1183,3 +1183,23 @@ end
 
     @test result == expected
 end
+
+@testset "Issue #208 - Wrong cell type with custom cells and showing row numbers" begin
+    table = Dict(
+        :x => ["totally not an a"],
+        :xx => [AnsiTextCell("a")],
+    )
+
+    expected = """
+┌─────┬──────────────┬──────────────────┐
+│ Row │           xx │                x │
+│     │ AnsiTextCell │           String │
+├─────┼──────────────┼──────────────────┤
+│   1 │            a\e[0m │ totally not an a │
+└─────┴──────────────┴──────────────────┘
+"""
+
+    result = pretty_table(String, table; show_row_number = true)
+
+    @test result == expected
+end