Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update ci to use go version from go.mod #24

Merged
merged 1 commit into from
Jul 9, 2024
Merged

chore(ci): update ci to use go version from go.mod #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,9 @@ on:
jobs:
lint:
uses: ./.github/workflows/lint.yml
with:
GO_VERSION: "1.21"

test:
uses: ./.github/workflows/test.yml
with:
GO_VERSION: "1.21"

# Make a release if this is a manually trigger job, i.e. workflow_dispatch
release:
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
name: lint
on:
workflow_call:
inputs:
GO_VERSION:
description: 'Go version to use'
type: string
required: true

jobs:
golangci-lint:
Expand All @@ -17,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v4
with:
go-version: ${{ inputs.GO_VERSION }}
go-version-file: ./go.mod
# This steps sets the GIT_DIFF environment variable to true
# if files defined in PATTERS changed
- uses: technote-space/[email protected]
Expand Down
11 changes: 3 additions & 8 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
name: Tests / Code Coverage
on:
workflow_call:
inputs:
GO_VERSION:
description: "Go version to use"
type: string
required: true

jobs:
go_mod_tidy_check:
Expand All @@ -17,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v4
with:
go-version: ${{ inputs.GO_VERSION }}
go-version-file: ./go.mod
- run: go mod tidy
- name: check for diff
run: git diff --exit-code
Expand All @@ -30,7 +25,7 @@ jobs:
- name: set up go
uses: actions/setup-go@v4
with:
go-version: ${{ inputs.GO_VERSION }}
go-version-file: ./go.mod
- name: Run unit test
run: make test
- name: upload coverage report
Expand All @@ -47,6 +42,6 @@ jobs:
- name: set up go
uses: actions/setup-go@v4
with:
go-version: ${{ inputs.GO_VERSION }}
go-version-file: ./go.mod
- name: Integration Tests
run: echo "No integration tests yet"
Loading