Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update bug-report.yml #28

Merged
merged 6 commits into from
Nov 18, 2024
Merged

chore(docs): Update bug-report.yml #28

merged 6 commits into from
Nov 18, 2024

Conversation

yarikbratashchuk
Copy link
Contributor

@yarikbratashchuk yarikbratashchuk commented Nov 15, 2024

Overview

Summary by CodeRabbit

  • New Features

    • Enhanced bug report template for improved clarity and detail.
    • Added sections for "Network Configuration" and "Development Environment."
  • Improvements

    • Updated prompts for version information and system specifications.
    • Refined sections for "Steps to Reproduce," "Expected Result," and "Actual Result" for better user guidance.
    • Clarified requests for relevant logs and additional information.

Copy link

coderabbitai bot commented Nov 15, 2024

Walkthrough

The pull request modifies the bug report template in the GitHub repository to improve clarity and detail in the information requested from users. Key changes include expanded introductory messages, renamed sections, and the introduction of new placeholders for various system and configuration details. Specific sections have been refined to guide users in providing comprehensive information about their environment, steps to reproduce issues, expected vs. actual results, and relevant logs.

Changes

File Path Change Summary
.github/ISSUE_TEMPLATE/bug-report.yml - Expanded introductory message for clarity.
- Renamed and detailed version information section.
- Updated system OS section to "System Information" with detailed specifications placeholders.
- Introduced "Network Configuration" section for network details.
- Rebranded "Installed tools" to "Development Environment" with updated descriptions.
- Renamed "Others" to "Configuration Details" with focused descriptions.
- Refined "Steps to reproduce it" to "Steps to Reproduce" with detailed placeholders.
- Updated "Expected result" and "Actual result" sections for clarity.
- Modified "Relevant log output" to "Relevant Logs" with clearer requests.
- Renamed "Notes" to "Additional Information" with expanded description.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Template
    User->>Template: Fill out bug report
    Template-->>User: Request detailed information
    User->>Template: Provide system info, steps to reproduce, logs
    Template-->>User: Confirm submission
Loading

🐰 "In the garden of code, where bugs do play,
A template now shines, brightening the way.
With fields for the details, so clear and so neat,
We'll hop through the issues, and make them retreat!
So gather your logs, and share with delight,
Together we'll fix them, and make things right!" 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (7)
.github/ISSUE_TEMPLATE/bug-report.yml (7)

15-15: Fix trailing whitespace.

Remove the trailing space after Git SHA: to comply with YAML formatting standards.

-        Git SHA: 
+        Git SHA:
🧰 Tools
🪛 GitHub Check: yamllint

[failure] 15-15:
15:17 [trailing-spaces] trailing spaces

🪛 yamllint

[error] 15-15: trailing spaces

(trailing-spaces)


15-21: Consider clarifying Git SHA format.

To help users provide the correct information, consider adding an example format for the Git SHA.

-        Git SHA:
+        Git SHA (full 40-character hash):
🧰 Tools
🪛 GitHub Check: yamllint

[failure] 15-15:
15:17 [trailing-spaces] trailing spaces

🪛 yamllint

[error] 15-15: trailing spaces

(trailing-spaces)


38-39: Consider adding format examples for memory and disk space.

To ensure consistent reporting, consider adding example formats for memory and disk space values.

-        Memory Size:
-        Available Disk Space:
+        Memory Size (e.g., 16GB):
+        Available Disk Space (e.g., 500GB):

42-53: Consider making Network Configuration required.

Given the distributed nature of the system, network configuration details are often crucial for debugging issues.

        P2P Port:
        RPC Port:
+    validations:
+      required: true

60-62: Consider adding version format examples.

To ensure consistent reporting, consider adding example version formats.

-        Docker Version:
-        Docker Compose Version:
-        Make Version:
+        Docker Version (e.g., 20.10.21):
+        Docker Compose Version (e.g., 2.12.2):
+        Make Version (e.g., 4.3):

82-83: Consider adding environment setup guidance.

To ensure reproducibility, consider adding more specific guidance about environment setup.

-        1. Initial setup steps
+        1. Initial setup steps (include fresh install vs existing environment)

114-121: Consider adding log format guidance.

To improve log readability and processing, consider adding specific format requirements.

        - System logs
-        Max 20 lines per component or provide gist/pastebin links
+        Max 20 lines per component or provide gist/pastebin links
+        Format: Include timestamps and log levels where available
+        Example: [2024-01-01 10:00:00] [ERROR] message
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between da0d7c3 and a7d9e6b.

📒 Files selected for processing (1)
  • .github/ISSUE_TEMPLATE/bug-report.yml (1 hunks)
🧰 Additional context used
🪛 GitHub Check: yamllint
.github/ISSUE_TEMPLATE/bug-report.yml

[failure] 15-15:
15:17 [trailing-spaces] trailing spaces

🪛 yamllint
.github/ISSUE_TEMPLATE/bug-report.yml

[error] 15-15: trailing spaces

(trailing-spaces)

🔇 Additional comments (4)
.github/ISSUE_TEMPLATE/bug-report.yml (4)

8-8: LGTM! Clear and welcoming introduction message.

The message effectively encourages users to provide detailed information while maintaining a friendly tone.


67-76: LGTM! Comprehensive configuration details section.

The section effectively captures various configuration aspects that could affect system behavior.


93-107: LGTM! Clear structure for expected and actual results.

The sections effectively guide users in providing clear comparisons between expected and actual behavior.


126-133: LGTM! Comprehensive additional information section.

The section effectively captures various additional details that could be relevant for debugging.

Manav-Aggarwal
Manav-Aggarwal previously approved these changes Nov 15, 2024
Copy link
Contributor

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this more generic and not specific to celestia and artela

.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (5)
.github/ISSUE_TEMPLATE/bug-report.yml (5)

8-8: Enhance the introduction message with template guidance.

Consider expanding the introduction to emphasize the importance of following the template structure.

-        Thank you for filling out this bug report! Please provide as much detail as possible to help us investigate.
+        Thank you for filling out this bug report! To help us investigate effectively:
+        - Please provide as much detail as possible
+        - Fill out all relevant sections of this template
+        - Use code blocks for logs and commands

31-38: Add additional system metrics for comprehensive debugging.

Consider adding these important system metrics to help diagnose performance-related issues:

         OS Type & Version:
         Architecture (arm64/amd64):
         Kernel Version (for Linux):
+        CPU Model & Cores:
         Memory Size:
+        Swap Space:
         Available Disk Space:
+        System Load Average:

41-52: Include network security and performance metrics.

Consider adding these network-related fields to help diagnose connectivity and security issues:

         Network Type (Testnet/Mainnet):
         Network ID:
         Chain ID:
         Connected Peers:
         P2P Port:
         RPC Port:
+        SSL/TLS Configuration:
+        Firewall Rules (if relevant):
+        Network Latency (ping times):
+        Bandwidth Limitations:

83-90: Add version control context and reproducibility information.

Consider adding these fields to help with issue reproduction:

         1. Initial setup steps
+        2. Git branch and commit hash
+        3. Clean environment confirmation
         2. Commands executed
         3. API calls made
         4. Expected trigger points
         5. Error occurrence timing
+        6. How often is this reproducible? (e.g., 100%, intermittent)

130-137: Add documentation references and environment comparisons.

Consider adding these fields to provide additional context:

         - Alternative reproduction methods
         - Related issues
         - Recent system changes
         - Workarounds attempted
         - Impact severity
+        - Relevant documentation links
+        - Does this work in a different environment? (e.g., local vs. staging)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a7d9e6b and b2dd625.

📒 Files selected for processing (1)
  • .github/ISSUE_TEMPLATE/bug-report.yml (1 hunks)
🔇 Additional comments (5)
.github/ISSUE_TEMPLATE/bug-report.yml (5)

12-21: Implementation matches previous review suggestions.


56-66: Implementation expands upon previous review suggestions appropriately.


70-79: Implementation expands upon previous review suggestions appropriately.


96-110: Well-structured result sections with clear guidance.

The expected and actual result sections provide comprehensive guidance for users to describe behaviors and outcomes.


116-125: Implementation expands upon previous review suggestions appropriately.

@MSevey MSevey changed the title Update bug-report.yml chore(docs): Update bug-report.yml Nov 18, 2024
@MSevey MSevey merged commit 5c79fab into main Nov 18, 2024
20 of 22 checks passed
@MSevey MSevey deleted the yarikbratashchuk-patch-1 branch November 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants