Correct issue with default.project.json files with no name being named default after change

[Dekkonot]

Closes #916.

Turns out we had a test that should've caught this, it's just that nobody caught it when this feature was implemented. We'll likely want to backport this into the 7.4.x branch as well.

Let me know if you have a better way to calculate project names in the middleware, I'm not in love with the way it's implemented here.

[kennethloeffler]

I think optional name handling should probably be consolidated into the project module. Having optional name logic done in two different places is harder to follow and gives too much room for mistakes, and I don't see any benefits in doing so.

I transferred the following block into a function in the project module (which is then called in Project::load_from_slice and Project::load_exact [maybe we should remove one of these too? I'm not sure why we need both]), and also moved the associated error variants into ProjectError:

rojo/src/serve_session.rs

Lines 121 to 147 in 3d4e387

	if root_project.name.is_none() {
	if let Some(file_name) = project_path.file_name().and_then(|s| s.to_str()) {
	if file_name == "default.project.json" {
	let folder_name = project_path
	.parent()
	.and_then(Path::file_name)
	.and_then(|s| s.to_str());
	if let Some(folder_name) = folder_name {
	root_project.name = Some(folder_name.to_string());
	} else {
	return Err(ServeSessionError::FolderNameInvalid {
	path: project_path.to_path_buf(),
	});
	}
	} else if let Some(trimmed) = file_name.strip_suffix(".project.json") {
	root_project.name = Some(trimmed.to_string());
	} else {
	return Err(ServeSessionError::ProjectNameInvalid {
	path: project_path.to_path_buf(),
	});
	}
	} else {
	return Err(ServeSessionError::ProjectNameInvalid {
	path: project_path.to_path_buf(),
	});
	}
	}

[kennethloeffler]

So there is a problem with the above approach: sync rules mean that project files won't necessarily have .project.json as a suffix, meaning that such files must contain a name field, otherwise the project will fail to load with ProjectNameInvalid. I think we should still allow a missing name field in this case (it should also have a test!). I'd still like the optional name logic to be defined in one place, so maybe we should give the project load functions a name parameter to fall back to in case we can't strip the .project.json suffix?

[Dekkonot]

I went through and redid the name resolution and it's now generalized. As long as we use the right methods on Project, it'll always work the same now.

In the process, I did modify project loading to always use a Vfs, which impacts the fmt-project subcommand. Nothing invasive though.

[kennethloeffler]

Looking good, just a couple comments:

[Dekkonot]

...I 100% brainfarted and added middleware to that last commit message even though it is not related to the middleware. Don't worry about it.