Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to Notify 4, use FSEvents, use minimal recursive watches #830

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Downgrade to Notify 4, use FSEvents, use minimal recursive watches #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d15966
Revert "Upgrade to Notify 6 (#816)"
kennethloeffler Jan 1, 2024
cf1012d
Revert "Use PollWatcher in memofs StdBackend on macOS (#783)"
kennethloeffler Jan 1, 2024
1ac085a
Minimize number of file watches
kennethloeffler Dec 29, 2023
7e3dc90
Update changelog
kennethloeffler Jan 2, 2024
dc5738f
Remove Rojo's notify dependency
kennethloeffler Jan 2, 2024
744d6e5
Update memofs changelog
kennethloeffler Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Rojo Changelog

## Unreleased Changes
* Significantly improved performance of `rojo serve`, `rojo build --watch`, and `rojo sourcemap --watch` on macOS. [#830]

[#830]: https://github.com/rojo-rbx/rojo/pull/830

## [7.4.0-rc3] - October 25, 2023
* Changed `sourcemap --watch` to only generate the sourcemap when it's necessary ([#800])
Expand Down Expand Up @@ -138,7 +141,6 @@
* Add buttons for navigation on the Connected page ([#722])

### Fixes
* Significantly improved performance of `rojo serve` and `rojo build` on macOS. [#783]
* Significantly improved performance of `rojo sourcemap` ([#668])
* Fixed the diff visualizer of connected sessions. ([#674])
* Fixed disconnected session activity. ([#675])
Expand Down Expand Up @@ -172,7 +174,6 @@
[#770]: https://github.com/rojo-rbx/rojo/pull/770
[#771]: https://github.com/rojo-rbx/rojo/pull/771
[#774]: https://github.com/rojo-rbx/rojo/pull/774
[#783]: https://github.com/rojo-rbx/rojo/pull/783
[rbx-dom#299]: https://github.com/rojo-rbx/rbx-dom/pull/299
[rbx-dom#296]: https://github.com/rojo-rbx/rbx-dom/pull/296

Expand Down
179 changes: 142 additions & 37 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion crates/memofs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# memofs Changelog

## Unreleased Changes
* Changed the `StdBackend` file watcher to use `PollWatcher` on macOS.
* Changed `StdBackend` file watching component to use minimal recursive watches. [#830]

[#830]: https://github.com/rojo-rbx/rojo/pull/830

## 0.2.0 (2021-08-23)
* Updated to `crossbeam-channel` 0.5.1.
Expand Down
2 changes: 1 addition & 1 deletion crates/memofs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ homepage = "https://github.com/rojo-rbx/rojo/tree/master/memofs"
[dependencies]
crossbeam-channel = "0.5.1"
fs-err = "2.3.0"
notify = "6.1.1"
notify = "4.0.15"
serde = { version = "1.0", features = ["derive"] }
Loading
Loading