Fix PatchTree incorrect changeList entries on decode failure #804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was testing #803, I discovered that
PatchTree.build
can create malformedchangeList
entries when a property decode fails. This causes errors when other parts of the system (such asDomLabel
) attempt to interact with them. The core of the problem is that we're usingnext
to obtain prop type-value pairs from the encoded property values in the incoming patch.next
returns multiple values (in this case, the type followed by the value), which are then passed as-is toaddProp
or the table cons. What we want instead is to only pass the prop value.This PR simply uses a
select
to only pass the prop value. I can also assign the result ofnext
to variables in these cases if we thinkselect
is too ugly...